On 30 Jun 2023, at 21:05, Eric Garver wrote:
Hi Eric,
I started reviewing the series, and this test was failing every other run for
me on ‘check-system-userspace’. I ended up making the following additional
change:
diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at
index d2e6ac768..573ecdd0f 100644
--- a/tests/ofproto-macros.at
+++ b/tests/ofproto-macros.at
@@ -120,7 +120,7 @@ strip_xids () {
# Changes all 'used:...' to say 'used:0.0', to make output easier to compare.
strip_used () {
- sed 's/used:[[0-9]]\.[[0-9]]*/used:0.0/'
+ sed 's/used:\([[0-9]]\.[[0-9]]*s\|never\)/used:0.0s/'
}
This is also the reason why the intel tests are failing in patchwork;
https://mail.openvswitch.org/pipermail/ovs-build/2023-June/032011.html
I still need to review the other patches in the series, but some small comments
while testing the patch set:
We are trying to align all commit messages to start with a Capital and end with
a dot. So in your case:
‘tests: system-traffic: Add coverage for drop action.’
> Signed-off-by: Eric Garver <e...@garver.life>
> ---
> tests/system-traffic.at | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/tests/system-traffic.at b/tests/system-traffic.at
> index 4c378e1d02b0..31c1ef46d561 100644
> --- a/tests/system-traffic.at
> +++ b/tests/system-traffic.at
> @@ -2048,6 +2048,36 @@ masks-cache:size:256
> OVS_TRAFFIC_VSWITCHD_STOP
> AT_CLEANUP
>
> +AT_SETUP([datapath - drop action])
> +OVS_TRAFFIC_VSWITCHD_START()
> +OVS_CHECK_DROP_ACTION()
> +AT_KEYWORDS(drop_action)
> +
> +ADD_NAMESPACES(at_ns0, at_ns1)
> +
> +ADD_VETH(p0, at_ns0, br0, "10.1.1.1/24")
> +ADD_VETH(p1, at_ns1, br0, "10.1.1.2/24")
> +
> +AT_DATA([flows.txt], [dnl
> +table=0, dl_type=0x806, actions=normal
> +table=0, in_port=ovs-p0, actions=goto_table:1
> +table=1, in_port=ovs-p0, actions=goto_table:2
> +table=2, in_port=ovs-p0, actions=resubmit(,1)
> +])
> +AT_CHECK([ovs-ofctl add-flows br0 flows.txt])
> +
> +dnl generate some traffic
‘Generate some traffic.’
> +NS_CHECK_EXEC([at_ns0], [ping -q -c 10 -i 0.1 -w 2 10.1.1.2], [1], [ignore])
> +
> +AT_CHECK([ovs-appctl dpctl/dump-flows | grep "eth_type(0x0800)" | dnl
> + sed 's/,packet_type(ns=[[0-9]]*,id=[[0-9]]*),/,/;s/,eth(),/,/;' |
> dnl
> + strip_recirc | strip_stats | strip_used | sort], [0], [dnl
> +recirc_id(<recirc>),in_port(2),eth_type(0x0800),ipv4(frag=no), packets:0,
> bytes:0, used:0.0s, actions:drop
> +])
> +
> +OVS_VSWITCHD_STOP(["/|WARN|/d"])
> +AT_CLEANUP
> +
> AT_SETUP([datapath - simulated flow action update])
> OVS_TRAFFIC_VSWITCHD_START()
>
> --
> 2.39.0
>
> _______________________________________________
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
