On 7/11/23 16:41, Eelco Chaudron wrote: > > > On 11 Jul 2023, at 16:33, Ilya Maximets wrote: > >> On 7/11/23 12:13, Eelco Chaudron wrote: >>> >>> >>> On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote: >>> >>>> This commit adds a few null pointer assertions and checks to some return >>>> values of `ovsdb_table_schema_get_column`. If a null pointer is >>>> encountered in these blocks, either the assertion will fail or the >>>> control flow will now be redirected to alternative paths which will >>>> output the appropriate error messages. >>>> >>>> A few ovsdb-rbac and ovsdb-server tests are also updated to verify the >>>> expected warning logs by adding said logs to the ALLOWLIST of the >>>> OVSDB_SERVER_SHUTDOWN statements. >>>> >>>> Signed-off-by: James Raphael Tiovalen <jamestio...@gmail.com> >>> >>> In general, this looks good, however, I’m not a ovsdb guy, so I’m wondering >>> if the asserts could not cause any additional crashes that can be avoided >>> by a different type of error handling. Also is there an easy way to make >>> this crash happen by giving some invalid input? >>> >>> Ilya any comments here? >> >> '_uuid' and '_version' are internal columns that must always exist. >> They are not part of the schema, ovsdb-server generates them. So, >> it must be an internal bug if they do not exist. > > Thanks for confirming/clarification. With this; > > Acked-by: Eelco Chaudron <echau...@redhat.com>
Thanks, James, Simon and Eelco! Applied this one. Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
