On 6/22/23 14:51, Dumitru Ceara wrote: > On 6/22/23 14:45, Dumitru Ceara wrote: >> On 6/22/23 13:56, Aaron Conole wrote: >>> Dumitru Ceara <dce...@redhat.com> writes: >>> >>>> This avoids manual intervention when upstream ovn-kubernetes changes >>>> its dependency versions. >>>> >>>> Signed-off-by: Patryk Diak <pd...@redhat.com> >>>> Co-authored-by: Patryk Diak <pd...@redhat.com> >>>> Signed-off-by: Dumitru Ceara <dce...@redhat.com> >>>> --- >>> >>> LGTM overall. It's also the only patch to have successfully built >>> recently, so I assume it will be important to apply for other patches to >>> succeed. >>> >> >> Thanks for the review! Yes, all other patches were failing ovn-kube CI >> when building the container image, effectively keeping us in the dark >> wrt effects on ovn-kubernetes. >> >>>> .ci/ovn-kubernetes/Dockerfile | 16 +++++++------- >>>> .ci/ovn-kubernetes/prepare.sh | 11 ++++++++++ >>>> .github/workflows/ovn-kubernetes.yml | 31 +++++++++++++++++----------- >>> >>> We got some warnings on this file due to line lengths. Maybe we should >>> exclude yml from the line length check. WDYT? >>> >> >> Sure, I can post a patch for that. Should I prepare a patch for OVS >> though? We normally try to keep our checkpatch version in sync with the >> OVS one. >> >>>> 3 files changed, 39 insertions(+), 19 deletions(-) >>> >>> Acked-by: Aaron Conole <acon...@redhat.com> >>> >> >> I pushed this patch to main. Hopefully the CI turns green soon. >> > > I forgot to mention: I added Patryk to the list of authors in AUTHORS.rst. >
I went ahead and applied this patch to branches 23.06 and 23.03. It applies cleanly there and, at least, we can get signal on some ovn-kubernetes jobs there too. Regards, Dumitru _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
