ok～ ---- Simon Jones
Aaron Conole <acon...@redhat.com> 于2023年7月27日周四 22:32写道： > Simon Jones <batmanu...@gmail.com> writes: > > > Hi Aaron, > > > > Thanks for your suggestion. This is my opinion as below. > > > > ---- > > Simon Jones > > > > Aaron Conole <acon...@redhat.com> 于2023年7月20日周四 23:41写道： > > > > Hi Simon, > > > > Thanks for the contribution! > > > > Simon Jones <batmanu...@gmail.com> writes: > > > > > From: simon <batmanu...@gmail.com> > > > > > > Fix bug of ovs-tcpdump, which will cause megaflow action wrong. > > > > > > As use ovs-tcpdump will add mipxxx NIC, and this NIC has IPv6 address > by > > > default. > > > > This is true only on systems where the ipv6 autoconf sysctl is set to > > true, I think. I think it is probably worth including that detail. > > > > > For vxlan topology, mipxxx will be treated as tunnel port, and will > got > > > error actions. > > > > > > For detail discuss, refer: > > > > https://github.com/batmancn/github-work/blob/main/ovs-bugfix-ovs-tcpdump.md > > > > Why not include some of these details in the commit message? At least, > > we can say that ipv6 packets going down the mirror port will cause > > erroneous behavior in most scenarios, and we should just stop ipv6 > > address there. > > > > Ok, how about change like this: > > I don't think we need the pointer to the markdown file after including > the details. > > > Fix bug of ovs-tcpdump, which will cause megaflow action wrong. > > maybe: > > ovs-tcpdump: clear auto-assigned ipv6 address of mirror port > > ovs-tcpdump will add mipxxx NIC, and on some systems this NIC has IPv6 > address by default. For vxlan topology, mipxxx, which has IPv6 > address, will be treated as tunnel port, and will got error actions. > > Prevent this by clearing the auto-assigned IPv6 address. This can also > be controlled on some systems with ipv6 sysctls. > > Tested on centos stream 8, and ubunto20.04 > > > As there is no IPv4 address, but has IPv6 by default, which is tested on > ubuntu and centos. > > So my patch is to clear IPv6 address on mipxxx NIC. > > > > > > Actually, I wonder if there should be any other steps we might need to > > take incase zeroconf is setup for ipv4 on the system, but hopefully that > > is managed separately. > > > > I have tested on ubuntu20.04 and centos stream 8, there is no IPv4 > address by default. > > I think for now this patch works. > > > > > > > Signed-off-by: simon <batmanu...@gmail.com> > > > --- > > > > Acked-by: Aaron Conole <acon...@redhat.com> > > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
