On 8/3/23 09:46, Ales Musil wrote:
> 
> 
> On Fri, Jul 14, 2023 at 5:25 PM Lorenzo Bianconi <lorenzo.bianc...@redhat.com 
> <mailto:lorenzo.bianc...@redhat.com>> wrote:
> 
>     Changes since v1:
>     - rebase on top of ovn main branch
>     - cosmetics
>     Changes since RFC v2:
>     - introduce ls_datapath_group column and deprecate datapath_group one.
>     Changes since RFC v1:
>     - get rid of patch 1/2: northd: rename table datapath_group in
>       ls_datapath_group in load_balancer sb db table
> 
>     Lorenzo Bianconi (2):
>       northd: sync lb applied to logical routers in sb db lb table
>       northd: introduce ls_datapath_group column in lb sb db table
> 
>      controller/chassis.c        |   8 +++
>      controller/lflow.c          |  10 +++
>      controller/local_data.c     |  16 +++++
>      controller/ovn-controller.c |  13 ++++
>      include/ovn/features.h      |   1 +
>      lib/lb.h                    |   3 +-
>      northd/northd.c             | 108 ++++++++++++++++++++++++++-------
>      northd/northd.h             |   1 +
>      ovn-sb.ovsschema            |  10 ++-
>      ovn-sb.xml                  |  12 ++++
>      tests/ovn-controller.at <http://ovn-controller.at>     |   4 ++
>      tests/ovn-northd.at <http://ovn-northd.at>         |  31 +++++++---
>      tests/system-ovn.at <http://system-ovn.at>         | 117 
> ++++++++++++++++++++++++++++++++++++
>      utilities/ovn-sbctl.c       |  13 ++++
>      14 files changed, 316 insertions(+), 31 deletions(-)
> 
>     -- 
>     2.41.0
> 
> 
> Looks good to me, thanks.
> 
> Reviewed-by: Ales Musil <amu...@redhat.com <mailto:amu...@redhat.com>>

I'd guess, this change may have a significant negative performance impact.
Do we have some scale testing numbers for it?  Not saying we shouldn't
fix the issue, but we should probably know what we're going into.

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to