On 8/2/23 10:27, Robin Jarry wrote:
> setup.py upload is now deprecated. When used, pypi.org returns an error:
> 
>> Upload failed (400): Invalid value for blake2_256_digest. Error: Use
>> a valid, hex-encoded, BLAKE2 message digest.

Nit: It might be better to just use 2-space indentation or some other way
of writing quotes instead of '>' to avoid interpretation by mail clients.

> 
> Use twine which is the recommended replacement tool to upload on
> pypi.org.
> 
> Link: 
> https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html#summary
> Reported-by: Terry Wilson <twil...@redhat.com>
> Signed-off-by: Robin Jarry <rja...@redhat.com>
> ---
>  python/automake.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/python/automake.mk b/python/automake.mk
> index 8b6266de214e..8854e656a5ae 100644
> --- a/python/automake.mk
> +++ b/python/automake.mk
> @@ -104,7 +104,7 @@ python-sdist: $(srcdir)/python/ovs/version.py 
> $(ovs_pyfiles) python/ovs/dirs.py
>       (cd python/ && $(PYTHON3) setup.py sdist)
>  
>  pypi-upload: $(srcdir)/python/ovs/version.py $(ovs_pyfiles) 
> python/ovs/dirs.py
> -     (cd python/ && $(PYTHON3) setup.py sdist upload)
> +     (cd python/ && $(PYTHON3) setup.py sdist && twine upload 
> dist/ovs-$(VERSION).tar.gz)

This target should just depend on python-sdist target where the first
part of the command is already defined.  No need for duplication.

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to