On Wed, Aug 09, 2023 at 10:58:14PM -0400, Mike Pattrick wrote:
> When the a revalidator thread is updating statistics for an XC_LEARN
> xcache entry in xlate_push_stats_entry it uses ofproto_flow_mod_learn.
> The revalidator will update stats for rules even if they are in a
> removed state or marked as invisible. However, ofproto_flow_mod_learn
> will detect if a flow has been removed and re-add it in that case. This
> can result in an old learn action replacing the new learn action that
> had replaced it in the first place.
> 
> This change adds a new force parameter to ofproto_flow_mod_learn
> allowing the caller to specify an action to take if temp_rule is
> removed. If force is set to false and the rule has been replaced in the
> classifier with a more recent rule, then ofproto_flow_mod_learn will
> just return.
> 
> Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2213892
> Signed-off-by: Mike Pattrick <m...@redhat.com>
> ---
> v2: Added additional checks if rule is removed
> v3: v2 patch was corrupted in transit

Hi Mike,

The following intel-ovs-compilation test failed.
Is this something that needs investigating in relation to your patch?
(I am unsure)

* 146: conntrack - IPv6 ICMP6 Related with SNAT        FAILED 
(system-traffic.at:6918)

Link: https://mail.openvswitch.org/pipermail/ovs-build/2023-August/032756.html
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to