Hi, Eelco,
No hurry, take your time!
Eelco Chaudron <echau...@redhat.com> 于2023年8月16日周三 16:43写道：
>
>
> On 16 Aug 2023, at 4:00, Peng He wrote:
>
> > Hi, Eelco,
> >
> > could you take a look at this patch?
>
> Hi Peng, yes it’s on my TODO list, but it might be a while as I’m
> recovering from three weeks of PTO ;)
>
> //Eelco
>
>
> >
> > Zhiqi Chen via dev <ovs-dev@openvswitch.org> 于2023年8月13日周日 17:09写道：
> >
> >> The 'len' of a netdev_flow_key initialized by netdev_flow_key_init()
> >> is always zero, which may cause errors when cloning a netdev_flow_key
> >> by netdev_flow_key_clone().
> >>
> >> Currently the 'len' member of a netdev_flow_key initialized by
> >> netdev_flow_key_init() is not used, so this error will not cause any
> >> bad behavior for now.
> >>
> >> Fixes: c82f496c3b69 ("dpif-netdev: Use unmasked key when adding datapath
> >> flows.")
> >> Signed-off-by: Zhiqi Chen <chenzhiqi....@bytedance.com>
> >> ---
> >> lib/dpif-netdev.c | 3 +--
> >> 1 file changed, 1 insertion(+), 2 deletions(-)
> >>
> >> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
> >> index 0b623fcea..0d8b1f4ae 100644
> >> --- a/lib/dpif-netdev.c
> >> +++ b/lib/dpif-netdev.c
> >> @@ -3380,14 +3380,13 @@ static inline void
> >> netdev_flow_key_init(struct netdev_flow_key *key,
> >> const struct flow *flow)
> >> {
> >> - uint64_t *dst = miniflow_values(&key->mf);
> >> uint32_t hash = 0;
> >> uint64_t value;
> >>
> >> miniflow_map_init(&key->mf, flow);
> >> miniflow_init(&key->mf, flow);
> >>
> >> - size_t n = dst - miniflow_get_values(&key->mf);
> >> + size_t n = miniflow_n_values(&key->mf);
> >>
> >> FLOW_FOR_EACH_IN_MAPS (value, flow, key->mf.map) {
> >> hash = hash_add64(hash, value);
> >> --
> >> 2.39.2 (Apple Git-143)
> >>
> >> _______________________________________________
> >> dev mailing list
> >> d...@openvswitch.org
> >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> >>
> >
> >
> > --
> > hepeng
>
>
--
hepeng
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
