Thanks Xavier,

Acked-by: Mark Michelson <mmich...@redhat.com>

On 9/18/23 12:46, Xavier Simonart wrote:
When ha-chassis-group is updated, causing a new hv to become master,
port move to a different chassis, and flows get created in table 
ls_in_dhcp_options.
If pb->chassis is reported empty by sb (because set to [] by the hv being the
previous owner of the port) those flows were deleted.
However, when pb->chassis is finally updated by sb (to the new hv), flows were
not re-installed, as runtime_data was not seen as updated.

This caused some random failures in test "external logical port".

Signed-off-by: Xavier Simonart <xsimo...@redhat.com>
---
  controller/binding.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/controller/binding.c b/controller/binding.c
index fd08aaafa..d48fd99aa 100644
--- a/controller/binding.c
+++ b/controller/binding.c
@@ -1362,6 +1362,7 @@ claim_lport(const struct sbrec_port_binding *pb,
              register_claim_timestamp(pb->logical_port, now);
              sset_find_and_delete(postponed_ports, pb->logical_port);
          } else {
+            update_tracked = true;
              if (!notify_up) {
                  if (!claimed_lport_set_up(pb, parent_pb, sb_readonly)) {
                      return false;

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to