On 30 Sep 2023, at 10:07, James R T wrote:
> On Thu, Sep 28, 2023 at 8:28 PM Eelco Chaudron <echau...@redhat.com> wrote: >> >> Move stuff in alphabetical order: >> >> #include <config.h> >> #undef NDEBUG >> #include <stdint.h> >> #include <stdio.h> >> #include <string.h> >> #include <sys/types.h> >> #include <unistd.h> >> #include "byteq.h" >> #include "ovstest.h" >> #include "util.h" >> > > Sure. > >> >> Is there an easy way to report this specific test is skipped on Windows? >> Maybe break out this test? See lockfile.at for an example. >> > > I can split that specific test (`test_byteq_write_read`) into another > function in the `test-byteq.c` file and guard it with an > `AT_SKIP_IF([test "$IS_WIN32" = "yes"])` in `library.at`. Would that > be more ac ceptable? I think this is what lockfile.at is doing, so that looks good to me. //Eelco _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
