On 10/18/23 9:34 PM, Ihar Hrachyshka wrote:
Yes. But also - this revealed a bug in ds_put_hex, where the first byte is NOT converted to two hex characters, but to one only. See the v2 series that includes the patch to fix the issue in ds_put_hex. That said, I wonder if this is "safe" to change the behavior of this basic library function. Let me know.
Nevermind. I realized that this function is used in lots of places in flow output and elsewhere. I don't think it justifies to modify its behavior for ovstest needs.
I could also reuse ds_put_hex but consider the length of the final string (if it's odd, then put an additional "0"). But regardless, I'd also have to truncate the initial "0x" prefix that is added by ds_put_hex.
Considering this, I will leave my own implementation of bin-to-hex in place and we can discuss in v2, if needed.
Ihar _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
