On 10/20/23 21:43, Ihar Hrachyshka wrote: > On Fri, Oct 20, 2023 at 12:26 PM Mark Michelson <mmich...@redhat.com> wrote: > >> The "IPv6 ND Router Solicitation responder" test was altered to test >> more cases. When the test was updated, the author updated the test to >> use fmt_pkt instead of constructing the packets by hand. Unfortunately, >> this change did not include the directive to skip the test if scapy is >> not installed. This commit adds the check so that systems that do not >> have scapy installed can still run tests appropriately. >> > > I'll bite... > > Why shouldn't we expect scapy installed during a test suite run? I'd post a > patch to remove HAVE_SCAPY and install scapy package in all CI jobs,
I think, it is already installed in our CI... > but > before I do, is there anything that makes it a bad idea? Failed tests should mean "problem with OVN itself". Tests should not fail due to issues in external tools. We even check for nc to be installed. Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
