On 27.10.23 17:25, Kevin Traynor wrote: > On 27/10/2023 14:38, Ilya Maximets wrote: >> On 10/26/23 11:29, Jakob Meng wrote: >>> On 25.10.23 19:10, Ilya Maximets wrote: >>>> ... >>>> Maybe something along these lines: >>>> >>>> - ovs-appctl: >>>> * Output of 'dpctl/show' command no longer shows interface >>>> configuration >>>> status, only values of the actual configuration options, a.k.a. >>>> 'requested' configuration. The interface configuration status, >>>> a.k.a. 'configured' values, can be found in the 'status' column of >>>> the Interface table, i.e. with 'ovs-vsctl get interface <..> >>>> status'. >>>> Reported names adjusted accordingly. >>>> >>>> What do you think? >>> >>> Simple and concise 👍 I will use that. However, we could add an example, >>> it could make it easier to grasp the meaning. >> >> I guess, the reference to 'configured' and 'requested' should be enough >> of an example. I think, if we would add an example, it should be very >> short, i.e. no longer than one extra line. This entry is already too long. >> >>> >>> Should I put the NEWS change in one of the patches or in a separate patch >>> 4/4? >> >> I'd say since the netdev-dpdk changes are the most noticeable, add the >> NEWS change into netdev-dpdk patch, but move the patch itself to the >> end of the set, so the NEWS entry is correct. >> >> Having a NEWS entry as a separate patch is not a good practice as if >> impairs ability to git blame the NEWS file. >> > > The plan above looks good to me too, > > Kevin.
Thank you both, Ilya and Kevin! I have incorporated your suggestions into v7: https://patchwork.ozlabs.org/project/openvswitch/list/?series=379901 (cover letter includes list of what was changed, but it's not listed in patchwork) _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
