On 27 Oct 2023, at 17:41, David Marchand wrote:
> On Fri, Oct 27, 2023 at 5:31 PM David Marchand > <david.march...@redhat.com> wrote: >> >> dpdk-testpmd does not need hugetlbfs backing as we don't require >> multiprocess support in OVS unit tests. >> >> Switch to --in-memory and remove the (then unneeded) check on >> hugetlbfs presence. >> >> Acked-by: Aaron Conole <acon...@redhat.com> >> Acked-by: Eelco Chaudron <echau...@redhat.com> >> Signed-off-by: David Marchand <david.march...@redhat.com> >> --- >> Changes since v7: >> - reverted use of dynamic allocations and kept initial memory >> reservation: this avoids random failures when testpmd and ovs-dpdk >> try to allocate memory at the same time, > > Just a heads up on this change. > > While testing the v8 series, I hit random failures on the mtu unit tests. > testpmd would fail to allocate memory in hugepages. > > I suspect this has to do with OVS allocating memory in // of testpmd. > Reverting to an initial reserved memory makes the issue disappear so I > removed this change and kept existing behavior. > There may still be a race underneath but at least the situation is as > bad as before. Hi David, I ran the full test 10 times, and it was not failing :( But I guess we should not apply, until your research has completed. Thanks, Eelco _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
