On 11/14/23 12:18, Ilya Maximets wrote:
> These are useful to spot build failures in different CI systems.
> For example, documentation build is failing for about 2 months
> now, the badge might help with spotting the issue earlier.
> 
> Signed-off-by: Ilya Maximets <i.maxim...@ovn.org>
> ---

Awesome!  One minor comment below though.

>  README.rst | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/README.rst b/README.rst
> index 74ae22f41..6fb717742 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -5,6 +5,17 @@
>  OVN
>  ===
>  
> +.. image:: 
> https://github.com/ovn-org/ovn/actions/workflows/test.yml/badge.svg
> +    :target: https://github.com/ovn-org/ovn/actions/workflows/test.yml
> +.. image:: 
> https://github.com/ovn-org/ovn/actions/workflows/ovn-kubernetes.yml/badge.svg
> +    :target: 
> https://github.com/ovn-org/ovn/actions/workflows/ovn-kubernetes.yml
> +.. image:: 
> https://github.com/ovn-org/ovn/actions/workflows/ovn-fake-multinode-tests.yml/badge.svg
> +    :target: 
> https://github.com/ovn-org/ovn/actions/workflows/ovn-fake-multinode-tests.yml
> +.. image:: https://api.cirrus-ci.com/github/ovn-org/ovn.svg
> +    :target: https://cirrus-ci.com/github/ovn-org/ovn
> +.. image:: https://readthedocs.org/projects/ovn/badge/?version=latest
> +    :target: https://docs.ovn.org/en/latest/

Shouldn't this point to https://readthedocs.org/projects/ovn/builds/
instead?  Like that we'd get redirected to the most recently executed
builds instead of the last successful docs page.

> +
>  What is OVN?
>  ---------------------
>  

Thanks,
Dumitru

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to