On Tue, Nov 14, 2023 at 05:59:37PM +0000, Ihar Hrachyshka wrote:
> With --bare, it will produce a bare hexified payload with no spaces or
> offset indicators inserted, which is useful in tests to produce frames
> to pass to e.g. `ovs-ofctl receive`.
> 
> With --bad-csum, it will produce a frame that has an invalid IP checksum
> (applicable to IPv4 only because IPv6 doesn't have checksums.)
> 
> The command is now more useful in tests, where we may need to produce
> hex frame payloads to compare observed frames against.
> 
> As an example of the tool use, a single test case is converted to it.
> The test uses both normal --bare and --bad-csum behaviors of the
> command, confirming they work as advertised.
> 
> Signed-off-by: Ihar Hrachyshka <ihrac...@redhat.com>

Thanks Ihar,

I have checked and as far as I can tell this addresses
the concerns raised by Ilya for v5.

Acked-by: Simon Horman <ho...@ovn.org>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to