On 11/10/23 18:52, David Marchand wrote: > Various options affect how the mcast snooping module work. > > When multicast snooping is enabled and a reporter is known, it is still > possible to flood associated packets to some other port via the > mcast-snooping-flood option. > > If flooding unregistered traffic is disabled, it is still possible to > flood multicast traffic too with the mcast-snooping-flood option. > > IGMP reports may have to be flooded to some ports explicitly with the > mcast-snooping-flood-reports option. > > Test those parameters. > > Signed-off-by: David Marchand <david.march...@redhat.com> > --- > Changes since v1: > - fixed dest mac address, > - added tests for mcast-snooping-disable-flood-unregistered=true and > mcast-snooping-flood-reports, > > --- > tests/mcast-snooping.at | 280 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 280 insertions(+) > > diff --git a/tests/mcast-snooping.at b/tests/mcast-snooping.at > index d5b7c4774c..b5474cf392 100644 > --- a/tests/mcast-snooping.at > +++ b/tests/mcast-snooping.at > @@ -105,6 +105,286 @@ AT_CHECK([ovs-appctl mdb/show br0], [0], [dnl > OVS_VSWITCHD_STOP > AT_CLEANUP > > + > +AT_SETUP([mcast - check multicast per port flooding]) > +OVS_VSWITCHD_START([]) > + > +AT_CHECK([ > + ovs-vsctl set bridge br0 \ > + datapath_type=dummy \ > + mcast_snooping_enable=true \ > + other-config:mcast-snooping-disable-flood-unregistered=false
Nit: Not a full review, but in case you're sending a new version for Eelco's comments, please, add more indentation to the 3 lines above, so they are not on the same level with ovs-vsctl. Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev