On Tue, Nov 28, 2023 at 9:40 AM David Marchand <david.march...@redhat.com> wrote: > > On Wed, Nov 22, 2023 at 5:34 PM David Marchand > <david.march...@redhat.com> wrote: > > > > The DPDK unit test only runs if vfio or igb_uio kernel modules are loaded: > > on systems with only mlx5, this test is always skipped. > > > > Besides, the test tries to grab the first device listed by dpdk-devbind.py, > > regardless of the PCI device status regarding kmod binding. > > > > Remove dependency on this DPDK script and use a minimal script that > > reads PCI sysfs. > > > > This script is not perfect, as one can imagine PCI devices bound to > > vfio-pci for virtual machines. > > Plus, this script only tries to take over vfio-pci devices. mlx5 devices > > can't be taken over blindly as it could mean losing connectivity to the > > machine if the netdev was in use for this system. > > > > For those two reasons, add a new environment variable DPDK_PCI_ADDR for > > testers to select the PCI device of their liking. > > For consistency and grep, the temporary file PCI_ADDR is renamed > > to DPDK_PCI_ADDR. > > > > Reviewed-by: Maxime Coquelin <maxime.coque...@redhat.com> > > Acked-by: Eelco Chaudron <echau...@redhat.com> > > Signed-off-by: David Marchand <david.march...@redhat.com> > > This patch can't be merged as is. > I am preparing some fixes for the system-dpdk MTU tests that got > merged since my v4.
Coming back on this. I sent a fix https://patchwork.ozlabs.org/project/openvswitch/patch/20231201142931.1782046-1-david.march...@redhat.com/. This current patch on making it possible to select a PCI device to test is kind of orthogonal to this fix. Yet, people will likely want to test with both applied. -- David Marchand _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
