On Tue, Dec 05, 2023 at 03:59:46PM +0100, Eelco Chaudron wrote:
> I ran 80 series of full tests, and the following tests showed failures:
> 
>  802.1ad - vlan_limit
>    +2023-11-20T10:32:11.245Z|00001|dpif_netdev(revalidator5)|ERR|internal
>      error parsing flow key recirc_id(0),dp_hash(0),skb_priority(0),
>      in_port(2),skb_mark(0),ct_state(0),ct_zone(0),ct_mark(0),ct_label(0),
>      packet_type(ns=0,id=0),eth(src=42:7e:4b:46:68:1b,dst=33:33:ff:46:68:1b),
>      eth_type(0x88a8),vlan(vid=4094,pcp=0),encap(eth_type(0x8100),
>      vlan(vid=100,pcp=0),encap(eth_type(0x86dd),ipv6(
>      src=::,dst=ff02::1:ff46:681b,label=0,proto=58,tclass=0,hlimit=255,
>      frag=no),icmpv6(type=135,code=0),nd(target=fe80::407e:4bff:fe46:681b,
>      sll=00:00:00:00:00:00,tll=00:00:00:00:00:00)))
>    +2023-11-20T10:32:11.245Z|00002|dpif(revalidator5)|WARN|netdev@ovs-netdev:
>      failed to put[modify] (Invalid argument)
>      ufid:ef1ca90c-dbd0-4ca7-9869-411bdffd1ece recirc_id(0),dp_hash(0/0),
>      skb_priority(0/0),in_port(2),skb_mark(0/0),ct_state(0/0),ct_zone(0/0),
>      ct_mark(0/0),ct_label(0/0),packet_type(ns=0,id=0),
>      eth(src=42:7e:4b:46:68:1b,dst=33:33:ff:46:68:1b),eth_type(0x88a8),
>      vlan(vid=4094,pcp=0/0x0),encap(eth_type(0x8100),
>      vlan(vid=100/0x0,pcp=0/0x0),encap(eth_type(0x86dd),
>      ipv6(src=::/::,dst=ff02::1:ff46:681b/::,label=0/0,proto=58/0,
>      tclass=0/0,hlimit=255/0,frag=no),icmpv6(type=135/0,code=0/0),
>      nd(target=fe80::407e:4bff:fe46:681b/::,
>      sll=00:00:00:00:00:00/00:00:00:00:00:00,
>      tll=00:00:00:00:00:00/00:00:00:00:00:00))), actions:drop
> 
>   conntrack - zones from other field, more tests
>     +2023-11-20T10:45:43.015Z|00001|dpif(handler5)|WARN|system@ovs-system:
>       execute ct(commit),3 failed (Invalid argument) on packet tcp,
>       vlan_tci=0x0000,dl_src=42:7e:4b:46:68:1b,dl_dst=ba:72:4c:a5:31:6b,
>       nw_src=10.1.1.1,nw_dst=10.1.1.2,nw_tos=0,nw_ecn=0,nw_ttl=64,
>       nw_frag=no,tp_src=53738,tp_dst=80,tcp_flags=psh|ack tcp_csum:e4a
> 
>   conntrack - limit by zone
>     ./system-traffic.at:5154: ovs-appctl dpctl/ct-get-limits zone=0,1,2,3,4,5
>     --- -     2023-11-20 10:51:09.965375141 +0000
>     +++ /home/runner/work/ovs/ovs/tests/system-kmod-testsuite.dir/at-groups/
>       114/stdout      2023-11-20 10:51:09.956723756 +0000
>     @@ -1,5 +1,5 @@
>      default limit=10
>     -zone=0,limit=5,count=5
>     +zone=0,limit=5,count=6
> 
>   conntrack - Multiple ICMP traverse
>     ./system-traffic.at:7571: ovs-appctl dpctl/dump-conntrack | ...
>       -e 's/state=[0-9_A-Z]*/state=<cleared>/g' | sort | uniq
>     --- -     2023-11-20 15:36:02.591051192 +0000
>     +++ /home/runner/work/ovs/ovs/tests/system-kmod-testsuite.dir/...
>     @@ -1,2 +1,9 @@
>     +tcp,orig=(src=10.1.1.7,dst=13.107.43.16,sport=<cleared>,
>       dport=<cleared>),reply=(src=13.107.43.16,dst=10.1.1.7,sport=<cleared>,
>       dport=<cleared>),protoinfo=(state=<cleared>)
>     +tcp,orig=(src=10.1.1.7,dst=168.63.129.16,sport=<cleared>,
>       dport=<cleared>),reply=(src=168.63.129.16,dst=10.1.1.7,sport=<cleared>,
>       dport=<cleared>),protoinfo=(state=<cleared>)
>     ...
>     +tcp,orig=(src=20.22.98.201,dst=10.1.1.7,sport=<cleared>,dport=<cleared>),
>       reply=(src=10.1.1.7,dst=20.22.98.201,sport=<cleared>,dport=<cleared>),
>       protoinfo=(state=<cleared>)
> 
>   conntrack - ct flush
>     +++ /home/runner/work/ovs/ovs/tests/system-kmod-testsuite.dir/...
>     @@ -1,3 +1,5 @@
>     +tcp,orig=(src=10.1.1.154,dst=13.107.42.16,sport=45300,dport=443),
>       reply=(src=13.107.42.16,dst=10.1.1.154,sport=443,dport=45300),
>       protoinfo=(state=ESTABLISHED)
>     +tcp,orig=(src=10.1.1.154,dst=20.72.125.48,sport=45572,dport=443),
>       reply=(src=20.72.125.48,dst=10.1.1.154,sport=443,dport=45572),
>       protoinfo=(state=ESTABLISHED)
> 
> As I do not see those failures when running these stand alone on the
> same Ubuntu distribution, I've disabled first three tests for now.

Hi Eelco,

I guess the change described above, and below address different problems,
and thus could be separate patches. But I don't feel particularly strongly
about this.

Reviewed-by: Simon Horman <ho...@kernel.org>

> For the other tests we narrowed the result to not include any of the local
> IP addresses in the test results.
> 
> This patch also adds the 'CHECK_GITHUB_ACTION' macro to skip
> tests that won't execute successfully through GitHub actions.
> We could not use the -k !keyword option, as it can not be
> combined with a range of tests.
> 
> Signed-off-by: Eelco Chaudron <echau...@redhat.com>

...
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to