On 15 Dec 2023, at 16:45, Simon Horman wrote:

> On Tue, Dec 05, 2023 at 04:00:41PM +0100, Eelco Chaudron wrote:
>> The testcase change will make sure the 'MFEX Configuration' test
>> will run without the need for scapy and it's auto generated tests.
>> In addition we exclude the traffic related MFEX tests from running
>> on GitHub actions due to limited resources.
>>
>> Signed-off-by: Eelco Chaudron <echau...@redhat.com>
>
> ...
>
>> diff --git a/python/test_requirements.txt b/python/test_requirements.txt
>> index c85ce41ad..5043c71e2 100644
>> --- a/python/test_requirements.txt
>> +++ b/python/test_requirements.txt
>> @@ -2,4 +2,5 @@ netaddr
>>  pyftpdlib
>>  pyparsing
>>  pytest
>> +scapy
>>  tftpy
>
> Hi Eelco,
>
> I'm having a bit of trouble reconciling the change above
> with the patch description.

Yes, this is for the remaining MFEX tests, which we exclude for Github, but 
they will not be run on your local system if you use the test_requermenrs file. 
I will update the commit message to mention this.

Something like:


Currently, if you use the python/test_requirements.txt file to
set up your test environment the MFEX tests will be skipped due
to the Scapy package not being included. This is fixed as part
of this patch.

The test case change will make sure the 'MFEX Configuration' test
will run without the need for Scapy and its auto-generated tests.

In addition, we exclude the traffic-related MFEX tests from running
on GitHub actions due to limited resources.


//Eelco

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to