On 20 Dec 2023, at 14:32, Simon Horman wrote:
> On Wed, Dec 20, 2023 at 02:23:16PM +0100, Eelco Chaudron wrote: >> >> >> On 20 Dec 2023, at 8:38, Eelco Chaudron wrote: >> >>> On 19 Dec 2023, at 19:45, Simon Horman wrote: >>> >>>> On Tue, Dec 19, 2023 at 06:38:57PM +0000, Simon Horman wrote: >>>>> On Tue, Dec 19, 2023 at 01:44:29PM +0100, Eelco Chaudron wrote: >>>>>> Currently, if you use the python/test_requirements.txt file to >>>>>> set up your test environment the MFEX tests will be skipped due >>>>>> to the Scapy package not being included. This is fixed as part >>>>>> of this patch. >>>>>> >>>>>> The test case change will make sure the 'MFEX Configuration' test >>>>>> will run without the need for Scapy and its auto-generated tests. >>>>>> >>>>>> In addition, we exclude the traffic-related MFEX tests from running >>>>>> on GitHub actions due to limited resources. >>>>>> >>>>>> Signed-off-by: Eelco Chaudron <[email protected]> >>>>> >>>>> Acked-by: Simon Horman <[email protected]> >>>> >>>> I do notice that, perhaps by chance, the GitHub actions failed >>>> on this particular patch as the linux clang test assan job >>>> ran for more than 30 minutes. >>>> >>>> Maybe we can bump timeout-minutes up a bit in build-and-test.yaml? >>> >>> Yes, I did notice this also, but I did over 200 runs on GitHub and it did >>> not happen before. So for now I assume it’s a glitch, but I plan to submit >>> another patch merging ubsan/asan (like OVN) and add this for some dp tests >>> also. Which will probably result in splitting the run. But this needs needs >>> this patch merged first. >>> >>> //Eelco >> >> Hi Simon, >> >> I noticed you marked the patch series as ‘change requested’, is this because >> of the above? If so, I do not think this should be part of this series. I >> looked at the recent runs, and this test takes an average of 13 minutes, so >> I assume something was wrong outside of OVS, with the Github infra causing >> the extreme delay. > > Yes, sorry, I was a bit hasty there. > I'll set the patches as "Under Review" and delegate them to you. > > Given your explanation above I have no objections to this series being > merged. Thanks, I’ll try to merge them before the end of the week! _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
