On 12/20/23 18:57, Adrian Moreno wrote:
> In general, most actions must be lists since the keys can be repeated.
> 
> Signed-off-by: Adrian Moreno <amore...@redhat.com>
> ---
>  python/ovs/flow/odp.py | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/python/ovs/flow/odp.py b/python/ovs/flow/odp.py
> index 46697a1bc..7d9b165d4 100644
> --- a/python/ovs/flow/odp.py
> +++ b/python/ovs/flow/odp.py
> @@ -375,13 +375,15 @@ class ODPFlow(Flow):
>                              KVDecoders(
>                                  decoders=_decoders,
>                                  default_free=decode_free_output,
> -                            )
> +                            ),
> +                            is_list=True,
>                          ),
>                          "le": nested_kv_decoder(
>                              KVDecoders(
>                                  decoders=_decoders,
>                                  default_free=decode_free_output,
> -                            )
> +                            ),
> +                            is_list=True,
>                          ),
>                      }
>                  )

Hi, Adrian.  This change breaks the pytest.  Please, adjust the
unit tests accordingly.

Speaking of tests, it might make sense to add some for other patches
in the set as well, if applicable.

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to