Dumitru Ceara <dce...@redhat.com> writes:
> On 1/17/24 21:40, Mark Michelson wrote:
>> On 1/16/24 11:23, Numan Siddique wrote:
>>> On Tue, Jan 16, 2024 at 8:09 AM Dumitru Ceara <dce...@redhat.com> wrote:
>>>>
>>>> This picks up the following OVS changes:
>>>> 00d3d4a7d375 ("checkpatch: Avoid catastrophic backtracking.")
>>>> d25c6bd8df37 ("checkpatch: Reorganize flagged words using a list.")
>>>> 9a50170a805a ("checkpatch: Add suggestions to the spell checker.")
>>>> 799f697e51ec ("checkpatch: Print subject field if misspelled or
>>>> missing.")
>>>> 1b8fa4a66aa4 ("checkpatch: Add checks for the subject line.")
>>>> bf843fd439b2 ("checkpatch: Don't spell check Fixes tag.")
>>>> 74bfe3701407 ("checkpatch: Add argument to skip committer signoff
>>>> check.")
>>>> 21c61243fb75 ("checkpatch: Fix personal word list storage.")
>>>> 915b97971d58 ("checkpatch.py: Load codespell dictionary.")
>>>>
>>>> Signed-off-by: Dumitru Ceara <dce...@redhat.com>
>>>
>>> Thanks for the patch.
>>>
>>> Acked-by: Numan Siddique <num...@ovn.org>
>>>
>>> Numan
>>
>> Thank you Dumitru and Numan.
>>
>> I merged this to main and all OVN branches back to 22.12.
>>
>
> Thanks, Numan and Mark!
>
>> I'm curious about something. Since we have the OVS submodule, and there
>> are no OVN-specific additions to checkpatch (that I'm aware of anyway),
>> would it make sense to remove the checkpatch from OVN and just rely on
>> the OVS submodule's checkpatch? This way, whenever we do a submodule
>> bump, we'd automatically pull in the checkpatch modifications.
>>
>> What do you think?
>>
>
> +1 I think we do have one OVN-specific change to checkpatch but I'm sure
> we can figure out how to have it ported to the OVS one if needed:
>
> https://github.com/ovn-org/ovn/commit/04a5527c6a8657b682450f71f7ee681512557b36
>
> On second thought maybe we don't even need this one ported. I think OVS
> has its own mitigation in place.
Yep - exactly.
> Another thing that took me by surprise is that 0-day bot always uses the
> OVS checkpatch script (that's why it didn't choke on Numan's I-P patch
> like OVN checkpatch did for me locally) - cc-ing Aaron.
It does? I thought it should be using the checkpatch that is included in
the OVN repo. That sounds like a bug. But if you decide to switch to
using the OVS one then maybe it becomes a feature. :)
> Regards,
> Dumitru
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
