On 1/23/24 11:55, Dumitru Ceara wrote:
[...]
>> +static void *
>> +en_lrp_claims_init(struct engine_node *node OVS_UNUSED, struct engine_arg
>> *arg OVS_UNUSED)
>
> Checkpatch reports "WARNING: Line is 90 characters long (recommended
> limit is 79)".
>
>> +{
>> + struct ed_type_lrp_claims *data = xzalloc(sizeof *data);
>> + data->lrp_claims = xzalloc(sizeof *(data->lrp_claims));
>> +
>> + data->lrp_claims->claim = NULL;
>> + data->lrp_claims->size = 0;
>> +
>> + return data;
>> +}
Running this through CI shows a memleak:
==18945==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 16 byte(s) in 1 object(s) allocated from:
#0 0x558463f97e88 in __interceptor_calloc
(/workspace/ovn-tmp/controller/ovn-controller+0x304e88) (BuildId:
b928f7b59bd18b4fec080b5a3a9f0098e471ec2a)
#1 0x55846437e94e in xcalloc__ /workspace/ovn-tmp/ovs/lib/util.c:124:31
#2 0x55846437e94e in xzalloc__ /workspace/ovn-tmp/ovs/lib/util.c:134:12
#3 0x55846437e94e in xzalloc /workspace/ovn-tmp/ovs/lib/util.c:168:12
#4 0x5584640d1ec7 in en_lrp_claims_init
/workspace/ovn-tmp/controller/ovn-controller.c:1470:24
#5 0x5584641dd636 in engine_init
/workspace/ovn-tmp/lib/inc-proc-eng.c:206:17
#6 0x5584640c73fe in main
/workspace/ovn-tmp/controller/ovn-controller.c:5447:5
#7 0x7f84fdd8fd8f (/lib/x86_64-linux-gnu/libc.so.6+0x29d8f) (BuildId:
c289da5071a3399de893d2af81d6a30c62646e1e)
One way to trigger CI is to push the patch to your GitHub fork.
For example, my run:
https://github.com/dceara/ovn/actions/runs/7624514129
Hope this helps,
Regards,
Dumitru
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
