On Wed, Jan 24, 2024 at 9:44 AM Mohammad Heib <mh...@redhat.com> wrote:
> Hi Ales, > > Yes sure that's what I'm planning to do next, i first wanted to make those > patches accepted upstream and then update the test case to use > the sync command, i guess it will be easier to review if send the test > cases change as a separate patch, what do you think? > Separate series/patch is completely fine once this series is accepted. Thanks, Ales > > On Fri, Jan 12, 2024 at 11:14 AM Ales Musil <amu...@redhat.com> wrote: > >> >> >> On Tue, Jan 9, 2024 at 2:29 PM Mohammad Heib <mh...@redhat.com> wrote: >> >>> Currently, OVN-IC doesn't support a way to tell the end-user when their >>> changes >>> to the IC-NB database have propagated successfully to the IC-SB Database. >>> >>> This patch series adds basic support for the sequence number status >>> protocol >>> that is implemented on the native OVN, with this patch series the end >>> user >>> now can wait for their changes in the IC-NB DB to take effect by >>> executing the >>> 'sync' command after applying any changes to the IC-NB DB, for example, >>> if the >>> end-user has created a transit switch in the IC-NB global DB and want to >>> make >>> sure that the IC-SB create a DP binding for this ts-switch the user now >>> can use >>> the 'sync' command as following: >>> $ ovn-ic-nbctl ts-add ts1 >>> $ ovn-ic-nbctl --wait=sb sync >>> >>> The second command will wait until all the ovn-ic instances see the new >>> changes >>> and update their own local dbs and the global IC-SB db. >>> >>> v3 -> v4 >>> -------- >>> * Addressed review comments from Ales to add check for the >>> overflow cases. >>> >>> v2 -> v3 >>> -------- >>> * Rebase over main. >>> * Addressed review comments from Mark and Ales. >>> >>> >>> Mohammad Heib (4): >>> OVN-IC: interconnect DBs add basic Information Flow columns >>> ovn-ic: implement basic INB change handling status >>> OVN-IC: Make it possible for CMS to detect when the ISB is up-to-date. >>> ic/tests: add unit test for ic sync command >>> >>> NEWS | 8 +++ >>> ic/ovn-ic.c | 96 ++++++++++++++++++++++++++++++++++-- >>> ovn-ic-nb.ovsschema | 6 ++- >>> ovn-ic-nb.xml | 17 +++++++ >>> ovn-ic-sb.ovsschema | 8 +-- >>> ovn-ic-sb.xml | 21 ++++++++ >>> tests/ovn-ic.at | 47 ++++++++++++++++++ >>> utilities/ovn-ic-nbctl.8.xml | 49 ++++++++++++++++++ >>> utilities/ovn-ic-nbctl.c | 89 ++++++++++++++++++++++++++++++++- >>> 9 files changed, 329 insertions(+), 12 deletions(-) >>> >>> -- >>> 2.34.3 >>> >>> _______________________________________________ >>> dev mailing list >>> d...@openvswitch.org >>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >>> >>> >> Hi Mohammad, >> >> thank you for the series. This suggestion is out of scope of this series, >> but it would be great to use the new sync across all ic tests that we >> currently have to further stabilize them. WDYT? >> >> Thanks, >> Ales >> >> >> -- >> >> Ales Musil >> >> Senior Software Engineer - OVN Core >> >> Red Hat EMEA <https://www.redhat.com> >> >> amu...@redhat.com >> <https://red.ht/sig> >> > -- Ales Musil Senior Software Engineer - OVN Core Red Hat EMEA <https://www.redhat.com> amu...@redhat.com <https://red.ht/sig> _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
