On 1/30/24 22:21, num...@ovn.org wrote:
> From: Numan Siddique <num...@ovn.org>
>
> This new engine now maintains the load balancer and NAT data of a
> logical router which was earlier part of northd engine node data.
> The main inputs to this engine are:
> - northd node
> - lr_nat node
> - lb_data node
>
> A record for each logical router is maintained in the 'lr_stateful_table'
> hmap table and this record
> - stores the lb related data
> - embeds the 'lr_nat' record.
>
> This engine node becomes an input to 'lflow' node.
>
> Signed-off-by: Numan Siddique <num...@ovn.org>
> ---
I have two small comments, style related, below. With those addressed:
Acked-by: Dumitru Ceara <dce...@redhat.com>
[...]
> +static void lr_stateful_table_build(struct lr_stateful_table *,
> + const struct lr_nat_table *,
> + const struct ovn_datapaths *lr_datapaths,
> + const struct hmap *lb_datapaths_map,
> + const struct hmap *lbgrp_datapaths_map);
Nit: indentation.
[...]
> +
> +static inline bool
> +lr_stateful_has_tracked_data(struct lr_stateful_tracked_data *trk_data) {
Nit: curly brace on next line.
Thanks,
Dumitru
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
