On 2/15/24 14:36, Simon Horman wrote: > On Thu, Feb 15, 2024 at 12:55:59PM +0100, Ilya Maximets wrote: >> The cited commit removed direct call to RSTP module from a callback, >> but we can still enter the module after going through a patch port >> to a different bridge via ofproto_dpif_send_packet(). >> >> Partially revert the change going back to a recursive mutex. >> >> Adding the same test for both RSTP and STP. While STP unit tests >> do catch the same problem for STP (if STP mutex changed to be >> non-recursive), they are not actually using the same callback function >> as ovs-vswitchd, so it makes sense to test the implementation in >> ovs-vswitchd itself as well. >> >> Fixes: 6b90bc57e7a2 ("lib/rstp: Remove lock recursion.") >> Reported-at: >> https://mail.openvswitch.org/pipermail/ovs-discuss/2024-February/052925.html >> Reported-by: Huangzhidong <huang.zhid...@h3c.com> >> Signed-off-by: Ilya Maximets <i.maxim...@ovn.org> > > Acked-by: Simon Horman <ho...@ovn.org> >
Thanks! Applied and backported down to 2.17. Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev