Bleep bloop. Greetings Adrian Moreno, I am a robot and I have tried out your patch. Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line has trailing whitespace #206 FILE: Documentation/ref/ovs-flowviz.8.rst:126: - json WARNING: Line is 81 characters long (recommended limit is 79) #544 FILE: Documentation/ref/ovs-flowviz.8.rst:464: [! | not ] {key}[[.subkey]...] [OPERATOR] {value})] [LOGICAL OPERATOR] ... WARNING: Line is 80 characters long (recommended limit is 79) #558 FILE: Documentation/ref/ovs-flowviz.8.rst:478: To compare against a match or info field, use the field directly, e.g: WARNING: Line is 80 characters long (recommended limit is 79) #565 FILE: Documentation/ref/ovs-flowviz.8.rst:485: Actions values might be dictionaries, use subkeys to access individual WARNING: Line is 110 characters long (recommended limit is 79) #601 FILE: Documentation/ref/ovs-flowviz.8.rst:521: $ ovs-flowviz -i flows.txt --style "light" --highlight "n_packets > 0 and drop" openflow html > flows.html WARNING: Line is 141 characters long (recommended limit is 79) #697 FILE: Documentation/topics/flow-visualization.rst:80: cookie=0xf76b4b20, duration=765.107s, table=0, n_packets=0, n_bytes=0, priority=180,vlan_tci=0x0000/0x1000 actions=conjunction(100,2/2) WARNING: Line is 328 characters long (recommended limit is 79) #698 FILE: Documentation/topics/flow-visualization.rst:81: cookie=0xf76b4b20, duration=765.107s, table=0, n_packets=0, n_bytes=0, priority=180,conj_id=100,in_port="patch-br-int-to",vlan_tci=0x0000/0x1000 actions=load:0xa->NXM_NX_REG13[],load:0xc->NXM_NX_REG11[],load:0xb->NXM_NX_REG12[],load:0xb->OXM_OF_METADATA[],load:0x1->NXM_NX_REG14[],mod_dl_src:02:42:ac:12:00:03,resubmit(,8) WARNING: Line is 286 characters long (recommended limit is 79) #699 FILE: Documentation/topics/flow-visualization.rst:82: cookie=0x0, duration=765.388s, table=0, n_packets=0, n_bytes=0, priority=100,in_port="ovn-6bb3b3-0" actions=move:NXM_NX_TUN_ID[0..23]->OXM_OF_METADATA[0..23],move:NXM_NX_TUN_METADATA0[16..30]->NXM_NX_REG14[0..14],move:NXM_NX_TUN_METADATA0[0..15]->NXM_NX_REG15[0..15],resubmit(,40) WARNING: Line is 286 characters long (recommended limit is 79) #700 FILE: Documentation/topics/flow-visualization.rst:83: cookie=0x0, duration=765.388s, table=0, n_packets=0, n_bytes=0, priority=100,in_port="ovn-a6ff98-0" actions=move:NXM_NX_TUN_ID[0..23]->OXM_OF_METADATA[0..23],move:NXM_NX_TUN_METADATA0[16..30]->NXM_NX_REG14[0..14],move:NXM_NX_TUN_METADATA0[0..15]->NXM_NX_REG15[0..15],resubmit(,40) WARNING: Line is 262 characters long (recommended limit is 79) #701 FILE: Documentation/topics/flow-visualization.rst:84: cookie=0xf2ca6195, duration=765.107s, table=0, n_packets=6, n_bytes=636, priority=100,in_port="ovn-k8s-mp0" actions=load:0x1->NXM_NX_REG13[],load:0x2->NXM_NX_REG11[],load:0x7->NXM_NX_REG12[],load:0x4->OXM_OF_METADATA[],load:0x2->NXM_NX_REG14[],resubmit(,8) WARNING: Line is 266 characters long (recommended limit is 79) #702 FILE: Documentation/topics/flow-visualization.rst:85: cookie=0x236e941d, duration=408.874s, table=0, n_packets=11, n_bytes=846, priority=100,in_port=aceac9829941d11 actions=load:0x11->NXM_NX_REG13[],load:0x2->NXM_NX_REG11[],load:0x7->NXM_NX_REG12[],load:0x4->OXM_OF_METADATA[],load:0x3->NXM_NX_REG14[],resubmit(,8) WARNING: Line is 268 characters long (recommended limit is 79) #703 FILE: Documentation/topics/flow-visualization.rst:86: cookie=0x3facf689, duration=405.581s, table=0, n_packets=11, n_bytes=846, priority=100,in_port="363ba22029cd92b" actions=load:0x12->NXM_NX_REG13[],load:0x2->NXM_NX_REG11[],load:0x7->NXM_NX_REG12[],load:0x4->OXM_OF_METADATA[],load:0x4->NXM_NX_REG14[],resubmit(,8) WARNING: Line is 268 characters long (recommended limit is 79) #704 FILE: Documentation/topics/flow-visualization.rst:87: cookie=0xe7c8c4bb, duration=405.570s, table=0, n_packets=11, n_bytes=846, priority=100,in_port="6a62cde0d50ef44" actions=load:0x13->NXM_NX_REG13[],load:0x2->NXM_NX_REG11[],load:0x7->NXM_NX_REG12[],load:0x4->OXM_OF_METADATA[],load:0x5->NXM_NX_REG14[],resubmit(,8) WARNING: Line is 266 characters long (recommended limit is 79) #705 FILE: Documentation/topics/flow-visualization.rst:88: cookie=0x99a0ffc1, duration=59.391s, table=0, n_packets=8, n_bytes=636, priority=100,in_port="5ff3bfaaa4eb622" actions=load:0x14->NXM_NX_REG13[],load:0x2->NXM_NX_REG11[],load:0x7->NXM_NX_REG12[],load:0x4->OXM_OF_METADATA[],load:0x6->NXM_NX_REG14[],resubmit(,8) WARNING: Line is 266 characters long (recommended limit is 79) #706 FILE: Documentation/topics/flow-visualization.rst:89: cookie=0xe1b5c263, duration=59.365s, table=0, n_packets=8, n_bytes=636, priority=100,in_port="8d9e0bc76347e59" actions=load:0x15->NXM_NX_REG13[],load:0x2->NXM_NX_REG11[],load:0x7->NXM_NX_REG12[],load:0x4->OXM_OF_METADATA[],load:0x7->NXM_NX_REG14[],resubmit(,8) WARNING: Line is 123 characters long (recommended limit is 79) #717 FILE: Documentation/topics/flow-visualization.rst:100: ├── priority=180 priority,conj_id,in_port,vlan_tci ---> load,load,load,load,load,mod_dl_src resubmit(,8), ( x 1 ) WARNING: Line is 86 characters long (recommended limit is 79) #718 FILE: Documentation/topics/flow-visualization.rst:101: ├── priority=100 priority,in_port ---> move,move,move resubmit(,40), ( x 2 ) WARNING: Line is 96 characters long (recommended limit is 79) #719 FILE: Documentation/topics/flow-visualization.rst:102: ├── priority=100 priority,in_port ---> load,load,load,load,load resubmit(,8), ( x 16 ) WARNING: Line is 104 characters long (recommended limit is 79) #720 FILE: Documentation/topics/flow-visualization.rst:103: ├── priority=100 priority,in_port,vlan_tci ---> load,load,load,load,load resubmit(,8), ( x 1 ) WARNING: Line is 114 characters long (recommended limit is 79) #721 FILE: Documentation/topics/flow-visualization.rst:104: ├── priority=100 priority,in_port,dl_vlan ---> strip_vlan,load,load,load,load,load resubmit(,8), ( x 1 ) WARNING: Line is 88 characters long (recommended limit is 79) #738 FILE: Documentation/topics/flow-visualization.rst:121: ├── priority=50 priority,reg14,metadata,dl_dst ---> load resubmit(,9), ( x 3 ) WARNING: Line is 94 characters long (recommended limit is 79) #739 FILE: Documentation/topics/flow-visualization.rst:122: └── priority=50 priority,metadata ---> load,move resubmit(,73),resubmit(,9), ( x 2 ) WARNING: Line is 88 characters long (recommended limit is 79) #750 FILE: Documentation/topics/flow-visualization.rst:133: $ ovs-flowviz -i flows.txt -f "table=8 and n_packets>0" openflow logic --ovn-detrace WARNING: Line is 106 characters long (recommended limit is 79) #753 FILE: Documentation/topics/flow-visualization.rst:136: ├── cookie=0xe10c34ee priority=50 priority,reg14,metadata,dl_dst ---> load resubmit(,9), ( x 1 ) WARNING: Line is 86 characters long (recommended limit is 79) #756 FILE: Documentation/topics/flow-visualization.rst:139: │ ├── * "ovn_cluster_router" (366e1c41-0f3d-4420-b796-10692b64e3e4) WARNING: Line is 176 characters long (recommended limit is 79) #757 FILE: Documentation/topics/flow-visualization.rst:140: │ ├── * Logical flow: table=0 (lr_in_admission), priority=50, match=(eth.mcast && inport == "rtos-ovn-worker2), actions=(xreg0[0..47] = 0a:58:0a:f4:01:01; next;) WARNING: Line is 128 characters long (recommended limit is 79) #758 FILE: Documentation/topics/flow-visualization.rst:141: │ └── * Logical Router Port: rtos-ovn-worker2 mac 0a:58:0a:f4:01:01 networks ['10.244.1.1/24'] ipv6_ra_configs {} WARNING: Line is 106 characters long (recommended limit is 79) #759 FILE: Documentation/topics/flow-visualization.rst:142: ├── cookie=0x11e1adbc priority=50 priority,reg14,metadata,dl_dst ---> load resubmit(,9), ( x 1 ) WARNING: Line is 82 characters long (recommended limit is 79) #762 FILE: Documentation/topics/flow-visualization.rst:145: │ ├── * "GR_ovn-worker2" (c07f8387-6479-4e81-9304-9f8e54f81c56) WARNING: Line is 179 characters long (recommended limit is 79) #763 FILE: Documentation/topics/flow-visualization.rst:146: │ ├── * Logical flow: table=0 (lr_in_admission), priority=50, match=(eth.mcast && inport == "rtoe-GR_ovn-worker2), actions=(xreg0[0..47] = 02:42:ac:12:00:03; next;) WARNING: Line is 131 characters long (recommended limit is 79) #764 FILE: Documentation/topics/flow-visualization.rst:147: │ └── * Logical Router Port: rtoe-GR_ovn-worker2 mac 02:42:ac:12:00:03 networks ['172.18.0.3/16'] ipv6_ra_configs {} WARNING: Line is 106 characters long (recommended limit is 79) #765 FILE: Documentation/topics/flow-visualization.rst:148: ├── cookie=0xf42133f priority=50 priority,reg14,metadata,dl_dst ---> load resubmit(,9), ( x 1 ) WARNING: Line is 82 characters long (recommended limit is 79) #768 FILE: Documentation/topics/flow-visualization.rst:151: │ ├── * "GR_ovn-worker2" (c07f8387-6479-4e81-9304-9f8e54f81c56) WARNING: Line is 198 characters long (recommended limit is 79) #769 FILE: Documentation/topics/flow-visualization.rst:152: │ ├── * Logical flow: table=0 (lr_in_admission), priority=50, match=(eth.dst == 02:42:ac:12:00:03 && inport == "rtoe-GR_ovn-worker2), actions=(xreg0[0..47] = 02:42:ac:12:00:03; next;) WARNING: Line is 131 characters long (recommended limit is 79) #770 FILE: Documentation/topics/flow-visualization.rst:153: │ └── * Logical Router Port: rtoe-GR_ovn-worker2 mac 02:42:ac:12:00:03 networks ['172.18.0.3/16'] ipv6_ra_configs {} WARNING: Line is 112 characters long (recommended limit is 79) #771 FILE: Documentation/topics/flow-visualization.rst:154: └── cookie=0x43a0327 priority=50 priority,metadata ---> load,move resubmit(,73),resubmit(,9), ( x 2 ) WARNING: Line is 85 characters long (recommended limit is 79) #775 FILE: Documentation/topics/flow-visualization.rst:158: ├── * "ovn-control-plane" (3262a782-8961-416b-805e-08233e8fda72) WARNING: Line is 83 characters long (recommended limit is 79) #776 FILE: Documentation/topics/flow-visualization.rst:159: ├── * "ext_ovn-worker2" (3f88dcd2-c56d-478f-a3b1-c7aee2efe967) WARNING: Line is 82 characters long (recommended limit is 79) #777 FILE: Documentation/topics/flow-visualization.rst:160: ├── * "ext_ovn-worker" (5facbaf0-485d-4cf5-8940-eff9678ef7bb) WARNING: Line is 89 characters long (recommended limit is 79) #778 FILE: Documentation/topics/flow-visualization.rst:161: ├── * "ext_ovn-control-plane" (8b0aecb6-b05a-48a7-ad09-72524bb91d40) WARNING: Line is 140 characters long (recommended limit is 79) #781 FILE: Documentation/topics/flow-visualization.rst:164: └── * Logical flow: table=0 (ls_in_check_port_sec), priority=50, match=(1), actions=(reg0[15] = check_in_port_sec(); next;) WARNING: Line is 103 characters long (recommended limit is 79) #813 FILE: Documentation/topics/flow-visualization.rst:196: ── recirc_id(0),in_port(3),eth(...),ipv4(...),tcp(dst=8181), actions:ct(zone=2,nat),recirc(0x19348) WARNING: Line is 155 characters long (recommended limit is 79) #814 FILE: Documentation/topics/flow-visualization.rst:197: │ ├── recirc_id(0x19348),in_port(3),ct_state(-new+est-rel-rpl-inv+trk),ct_label(0/0x3),eth(...),eth_type,ipv4(), actions:ct(zone=27,nat),recirc(0x10) WARNING: Line is 107 characters long (recommended limit is 79) #815 FILE: Documentation/topics/flow-visualization.rst:198: │ │ ├── recirc_id(0x10),in_port(3),ct_state(-new+est-rel-rpl-inv+trk),eth(...),ipv4(...), actions:9 WARNING: Line is 107 characters long (recommended limit is 79) #816 FILE: Documentation/topics/flow-visualization.rst:199: │ │ ├── recirc_id(0x10),in_port(3),ct_state(-new+est-rel+rpl-inv+trk),eth(...),ipv4(...), actions:9 WARNING: Line is 138 characters long (recommended limit is 79) #817 FILE: Documentation/topics/flow-visualization.rst:200: │ │ └── recirc_id(0x10),in_port(3),ct_state(+new-est-rel-rpl-inv+trk),eth(...),ipv4(...), actions:ct(commit,zone=27,label=0/0x1),9 WARNING: Line is 164 characters long (recommended limit is 79) #818 FILE: Documentation/topics/flow-visualization.rst:201: │ └── recirc_id(0x19348),in_port(3),ct_state(+new-est-rel-rpl-inv+trk),eth(...),ipv4(...), actions:ct(commit,zone=2,label=0/0x1),ct(zone=27,nat),recirc(0x10) WARNING: Line is 107 characters long (recommended limit is 79) #819 FILE: Documentation/topics/flow-visualization.rst:202: │ ├── recirc_id(0x10),in_port(3),ct_state(-new+est-rel-rpl-inv+trk),eth(...),ipv4(...), actions:9 WARNING: Line is 107 characters long (recommended limit is 79) #820 FILE: Documentation/topics/flow-visualization.rst:203: │ ├── recirc_id(0x10),in_port(3),ct_state(-new+est-rel+rpl-inv+trk),eth(...),ipv4(...), actions:9 WARNING: Line is 138 characters long (recommended limit is 79) #821 FILE: Documentation/topics/flow-visualization.rst:204: │ └── recirc_id(0x10),in_port(3),ct_state(+new-est-rel-rpl-inv+trk),eth(...),ipv4(...), actions:ct(commit,zone=27,label=0/0x1),9 WARNING: New doc ovs-flowviz.8.rst not listed in Documentation/automake.mk Lines checked: 901, Warnings: 51, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev