On Mon, Mar 25, 2024 at 10:37:16AM -0700, Jakub Kicinski wrote: > genetlink.h is a shell of what used to be a combined uAPI > and kernel header over a decade ago. It has fewer than > 10 lines of code. Merge it into net/genetlink.h. > In some ways it'd be better to keep the combined header > under linux/ but it would make looking through git history > harder.
Some last moment minor comments (no need to send a new version, JFYI, maybe you tide this up when applying). ... > +/* Non-parallel generic netlink requests are serialized by a global lock. */ While at it, maybe drop extra space? (I noticed it was originally like this. ... > +#define MODULE_ALIAS_GENL_FAMILY(family) \ > + MODULE_ALIAS_NET_PF_PROTO_NAME(PF_NETLINK, NETLINK_GENERIC, "-family-" > family) I would still make this TAB indented. -- With Best Regards, Andy Shevchenko _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
