On 3/27/24 22:07, Mike Pattrick wrote: > On Wed, Mar 27, 2024 at 1:39 PM Simon Horman <ho...@ovn.org> wrote: >> >> On Tue, Feb 20, 2024 at 11:08:55PM -0500, Mike Pattrick wrote: >>> When sending packets that are flagged as requiring segmentation to an >>> interface that doens't support this feature, send the packet to the TSO >>> software fallback instead of dropping it. >>> >>> Signed-off-by: Mike Pattrick <m...@redhat.com> >> >> Hi Mike, >> >> Can I confirm that from your PoV this patch is still awaiting review? >> I ask because it's been sitting around for a while now. > > I believe this patch now needs to be modified for the recent > recirculation change. I'll update it for that, give it another once > over, and resubmit.
While at it, please, check that the outer UDP header is correctly updated. It is likely not, according to the tests done here: https://github.com/openvswitch/ovs-issues/issues/321#issuecomment-2008592610 It seem to keep the length that is larger than IP payload size. If so, some unit tests for this functionality would be nice to have as well with the actual comparison of headers for different packets. Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
