Clang's static analyzer will complain about an uninitialized value because we weren't setting a value for ufid_generated in all code paths.
Now we initialize this on declaration. Signed-off-by: Mike Pattrick <[email protected]> --- lib/dpctl.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/dpctl.c b/lib/dpctl.c index 3c555a559..9c287d060 100644 --- a/lib/dpctl.c +++ b/lib/dpctl.c @@ -1366,12 +1366,11 @@ dpctl_del_flow_dpif(struct dpif *dpif, const char *key_s, struct ofpbuf mask; /* To be ignored. */ ovs_u128 ufid; - bool ufid_generated; - bool ufid_present; + bool ufid_generated = false; + bool ufid_present = false; struct simap port_names; int n, error; - ufid_present = false; n = odp_ufid_from_string(key_s, &ufid); if (n < 0) { dpctl_error(dpctl_p, -n, "parsing flow ufid"); -- 2.39.3 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
