On 5/15/24 14:15, Amit Prakash Shukla wrote:
> Packet that are not encapsulated but metadata of the packet contains
> a offload flag set, will call dp_packet_inner_l4 to get TCP, UDP, SCTP
> header pointers. dp_packet_inner_l4 for such packets would return NULL
> as the inner offsets by-default are configured as UINT16_MAX. On
> derefrencing such pointers, segfault is observed.
> 
> Add assert check for packets with incorrect header or incorrect
> offload flag set.
> 
> Signed-off-by: Amit Prakash Shukla <[email protected]>
> ---
> v2:
> - Added Fixes tag and updated commit message.
> 
> v3:
> - Resolved review comment - added assert.
> - Updated patch subject and commit message.
> 
> v4:
> - Fixed checkpatch warning.

Thanks!  I added a note to the commit message that the crash was not
related to OVS logic and applied the change.

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to