On Tue, May 28, 2024 at 4:26 PM Ilya Maximets <[email protected]> wrote: > > On 5/27/24 21:08, Mike Pattrick wrote: > > Clang's static analyzer noted that the output from > > netdev_linux_get_speed_locked can be checked even if this function > > doesn't set any values. > > > > Now we always set those values to a sane default in all cases. > > > > Fixes: b8f8fad86435 ("netdev-linux: Use speed as max rate in tc classes.") > > This is still an incorrect Fixes tag. The correct one is: > > Fixes: 19cffe30cfda ("netdev-linux: Avoid deadlock in netdev_get_speed.")
Sorry about that, I thought I had corrected it when resubmitting, but it looks like this slipped through. Cheers, M > > The original netdev_get_speed() call was fine, because it ensures that values > are zeroed out even on errors. That is defined in netdev-provider API. But > the new static netdev_linux_get_speed_locked() function didn't do the same. > > I fixed that and applied the set. Individual patches backported according to > their Fixes tags. Thanks! > > Best regards, Ilya Maximets. > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
