On 28 May 2024, at 19:56, Paolo Valerio wrote:
> Eelco Chaudron <[email protected]> writes: > >> Fix the warning from Coverity about potential truncation of the >> time_t value when copying to a local variable by changing the >> local variable's type to time_t. >> >> ccc24fc88d59 ("ofproto-dpif: APIs and CLI option to add/delete static fdb >> entry.") > > It seems "Fixes:" slipped out here. > I guess this could be fixed while applying. > That aside, > > Acked-by: Paolo Valerio <[email protected]> Thanks Paolo for the review. I’ll make sure it gets fixed on commit if no new version is required. >> Signed-off-by: Eelco Chaudron <[email protected]> >> --- >> ofproto/ofproto-dpif.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c >> index 32d037be6..fcd7cd753 100644 >> --- a/ofproto/ofproto-dpif.c >> +++ b/ofproto/ofproto-dpif.c >> @@ -6097,7 +6097,7 @@ ofproto_unixctl_fdb_add(struct unixctl_conn *conn, int >> argc OVS_UNUSED, >> const char *port_name = argv[2]; >> uint16_t vlan = atoi(argv[3]); >> struct eth_addr mac; >> - int age; >> + time_t age; >> >> ofproto = ofproto_dpif_lookup_by_name(br_name); >> if (!ofproto) { >> -- >> 2.44.0 >> >> _______________________________________________ >> dev mailing list >> [email protected] >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
