On 28/05/2024 20:12, Ilya Maximets wrote:
> On 5/26/24 10:31, Roi Dayan via dev wrote:
>> From: Maor Dickman <ma...@nvidia.com>
>>
>> The cited commit reserved lower tc priorities for IP ethertypes in order
>> to give IP traffic higher priority than other management traffic.
>> In case of of vlan encap traffic, IP traffic will still get lower
>> priority.
>>
>> Fix it by also reserving low priority tc prio for vlan.
>>
>> Fixes: c230c7579c14 ("netdev-offload-tc: Reserve lower tc prios for ip
>> ethertypes")
>> Signed-off-by: Maor Dickman <ma...@nvidia.com>
>> Acked-by: Roi Dayan <r...@nvidia.com>
>> ---
>> lib/netdev-offload-tc.c | 2 ++
>> lib/tc.h | 1 +
>> 2 files changed, 3 insertions(+)
>>
>> diff --git a/lib/netdev-offload-tc.c b/lib/netdev-offload-tc.c
>> index 921d5231777e..3be1c08d24f6 100644
>> --- a/lib/netdev-offload-tc.c
>> +++ b/lib/netdev-offload-tc.c
>> @@ -400,6 +400,8 @@ get_next_available_prio(ovs_be16 protocol)
>> return TC_RESERVED_PRIORITY_IPV4;
>> } else if (protocol == htons(ETH_P_IPV6)) {
>> return TC_RESERVED_PRIORITY_IPV6;
>> + } else if (protocol == htons(ETH_P_8021Q)) {
>
> Should 802.1ad traffic also get the priority?
> What about MPLS?
>
> Best regards, Ilya Maximets.
Hi Ilya,
It is correct there could be more types that could benefit from a reserved
prio but from what we saw in the field we didn't notice a real usage
of 802.1ad or MPLS while 8021q was being used actively and we noticed the
performance degradation and improvement after using the reserved prio.
We think this patch can help many active openvswitch users and in the future
if other types would be more common we could add those.
Thanks,
Roi
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
