On 31 May 2024, at 13:37, Ilya Maximets wrote:
> On 5/29/24 12:53, Eelco Chaudron wrote:
>> This patch fixes an uninitialized gso_type case in
>> netdev_linux_prepend_vnet_hdr() by returning an error.
>>
>> Fixes: 3337e6d91c5b ("userspace: Enable L4 checksum offloading by default.")
>> Signed-off-by: Eelco Chaudron <echau...@redhat.com>
>> ---
>> lib/netdev-linux.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
>> index eb0c5c624..dc67e1268 100644
>> --- a/lib/netdev-linux.c
>> +++ b/lib/netdev-linux.c
>> @@ -7167,6 +7167,10 @@ netdev_linux_prepend_vnet_hdr(struct dp_packet *b,
>> int mtu)
>> vnet->gso_type = VIRTIO_NET_HDR_GSO_TCPV4;
>> } else if (dp_packet_hwol_tx_ipv6(b)) {
>> vnet->gso_type = VIRTIO_NET_HDR_GSO_TCPV6;
>> + } else {
>> + VLOG_ERR_RL(&rl, "Unknown gso_type for TSO packet. Flags:
>> %"PRIx64,
>
> I'd suggest adding the # qualifier to the format string, i.e. %#"PRIx64.
> Can be fixed on commit, I suppose.
Thanks for the review! I’ll fix on commit, as I totally missed the # sign :(.
> Acked-by: Ilya Maximets <i.maxim...@ovn.org>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
