On 5/31/24 16:10, Kevin Traynor wrote:
> On 30/05/2024 14:10, David Marchand wrote:
>> All informations required for checksum offloading can be deducted by
> 
> nit:  "All information required for checksum offloading can be deduced
> by" can update on applying, assuming no more revs are needed.
> 
>> already tracked dp_packet l3_ofs, l4_ofs, inner_l3_ofs and inner_l4_ofs
>> fields.
>> Remove DPDK specific l[2-4]_len from generic OVS code.
>>
>> netdev-dpdk code then fills mbuf specifics step by step:
>> - outer_l2_len and outer_l3_len are needed for tunneling (and below
>>   features),
>> - l2_len and l3_len are needed for IP and L4 checksum (and below features),
>> - l4_len and tso_segsz are needed when doing TSO,
>>
>> Signed-off-by: David Marchand <david.march...@redhat.com>
>> ---
>>  lib/dp-packet.h         | 37 ------------------------------
>>  lib/netdev-dpdk.c       | 35 ++++++++++++++++++-----------
>>  lib/netdev-native-tnl.c | 50 +++++------------------------------------
>>  3 files changed, 27 insertions(+), 95 deletions(-)
> 
> Acked-by: Kevin Traynor <ktray...@redhat.com>

Thanks, David and Kevin!

I generally like the direction of this patch set, especially the
cleanup of the generic tunnel code.

I didn't test it with a real hardware nor I re-checked the math,
so will not Ack it, but it looks good to me otherwise, and I think
we should backport the whole thing to at least branch-3.3 as well.

Best regards, Ilya Maximets.

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to