On Wed, Jun 05, 2024 at 08:29:22AM GMT, kernel test robot wrote: > Hi Adrian, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on net-next/main] > > url: > https://github.com/intel-lab-lkp/linux/commits/Adrian-Moreno/net-psample-add-user-cookie/20240604-030055 > base: net-next/main > patch link: > https://lore.kernel.org/r/20240603185647.2310748-6-amorenoz%40redhat.com > patch subject: [PATCH net-next v2 5/9] net: openvswitch: add emit_sample > action > config: s390-randconfig-002-20240605 > (https://download.01.org/0day-ci/archive/20240605/202406050852.hdtfsko0-...@intel.com/config) > compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project > d7d2d4f53fc79b4b58e8d8d08151b577c3699d4a) > reproduce (this is a W=1 build): > (https://download.01.org/0day-ci/archive/20240605/202406050852.hdtfsko0-...@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version > of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <l...@intel.com> > | Closes: > https://lore.kernel.org/oe-kbuild-all/202406050852.hdtfsko0-...@intel.com/ > > All errors (new ones prefixed by >>): > > s390x-linux-ld: net/openvswitch/actions.o: in function > `do_execute_actions': > >> actions.c:(.text+0x1d5c): undefined reference to `psample_sample_packet' >
Thanks robot! OK, I think I know what's wrong. There is an optional dependency with PSAMPLE. Openvswitch module does compile without PSAMPLE but there is a link error if OPENVSWITCH=y and PSAMPLE=m. Looking into how to express this in the Kconfig, I'm planning to add the following to the next version of the series. diff --git a/net/openvswitch/Kconfig b/net/openvswitch/Kconfig index 29a7081858cd..2535f3f9f462 100644 --- a/net/openvswitch/Kconfig +++ b/net/openvswitch/Kconfig @@ -10,6 +10,7 @@ config OPENVSWITCH (NF_CONNTRACK && ((!NF_DEFRAG_IPV6 || NF_DEFRAG_IPV6) && \ (!NF_NAT || NF_NAT) && \ (!NETFILTER_CONNCOUNT || NETFILTER_CONNCOUNT))) + depends on PSAMPLE || !PSAMPLE select LIBCRC32C select MPLS select NET_MPLS_GSO _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev