On 12 Jul 2024, at 1:32, Adrian Moreno wrote:

> Add a command to dump statistics per exporter.
>
> Signed-off-by: Adrian Moreno <amore...@redhat.com>

Changes look good to me. Small nit below, but I'm fine either way so;

Acked-by: Eelco Chaudron <echau...@redhat.com>

> ---
>  NEWS                           |   2 +
>  ofproto/ofproto-dpif-lsample.c | 111 +++++++++++++++++++++++++++++++++
>  ofproto/ofproto-dpif-lsample.h |   2 +
>  ofproto/ofproto-dpif.c         |   1 +
>  4 files changed, 116 insertions(+)
>
> diff --git a/NEWS b/NEWS
> index 5f5871ef0..096ff4d7d 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -20,6 +20,8 @@ Post-v3.3.0
>       allows samples to be emitted locally (instead of via IPFIX) in a
>       datapath-specific manner.  The Linux kernel datapath is the first to
>       support this feature by using the new datapath "psample" action.
> +   - A new unixctl command 'lsample/show' shows packet and bytes statistics

Should we maybe move this to the '- ovs-appctl:' section above?

> +     per local sample exporter.

<SNIP>

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to