On Fri, Aug 16, 2024 at 9:44 AM Eelco Chaudron <echau...@redhat.com> wrote:
>
>
>
> On 31 Jul 2024, at 6:49, Mike Pattrick wrote:
>
> > Previously the OVS support for checksum/TSO offloading didn't work well
> > with some network cards that supported VXLAN/Geneve tunnel TSO but not
> > outer UDP checksums. Now support for this configuration is improved and
> > we no longer need to disable the VXLAN/Geneve TSO flags from intel
> > hardware support flags.
>
> I think Ilya already requested this earlier, can we point out which 
> improvements (DPDK and/or OVS commit IDs maybe)?

Hello Eelco,

I can further clarify this commit message. I'll send out a new version.


Cheers,
M

>
> > The modification to outer UDP offload is still required pending a future
> > DPDK release.
> >
> > Suggested-by: David Marchand <david.march...@redhat.com>
> > Reviewed-by: David Marchand <david.march...@redhat.com>
> > Signed-off-by: Mike Pattrick <m...@redhat.com>
> > ---
> >  lib/netdev-dpdk.c | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
> > index 02cef6e45..95a78241d 100644
> > --- a/lib/netdev-dpdk.c
> > +++ b/lib/netdev-dpdk.c
> > @@ -1363,8 +1363,6 @@ dpdk_eth_dev_init(struct netdev_dpdk *dev)
> >                    "net/ice, net/i40e or net/iavf port.",
> >                    netdev_get_name(&dev->up));
> >          info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM;
> > -        info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO;
> > -        info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO;
> >      }
> >
> >      if (info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_IPV4_CKSUM) {
> > --
> > 2.43.5
> >
> > _______________________________________________
> > dev mailing list
> > d...@openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to