On Thu, Aug 15, 2024 at 08:22:45PM GMT, Menglong Dong wrote: > I'm sure if I understand it correctly, but it seems that there is > something wrong with ovs_drop_reasons. > > ovs_drop_reasons[0] is "OVS_DROP_LAST_ACTION", but > OVS_DROP_LAST_ACTION == __OVS_DROP_REASON + 1, which means that > ovs_drop_reasons[1] should be "OVS_DROP_LAST_ACTION". > > Fix this by initializing ovs_drop_reasons with index. > > Fixes: 9d802da40b7c ("net: openvswitch: add last-action drop reason") > Signed-off-by: Menglong Dong <dong...@chinatelecom.cn>
The patch looks good to me. Also, tested and verified that, without the patch, adding flow to drop packets results in: drop at: do_execute_actions+0x197/0xb20 [openvsw (0xffffffffc0db6f97) origin: software input port ifindex: 8 timestamp: Tue Aug 20 10:19:17 2024 859853461 nsec protocol: 0x800 length: 98 original length: 98 drop reason: OVS_DROP_ACTION_ERROR With the patch, the same results in: drop at: do_execute_actions+0x197/0xb20 [openvsw (0xffffffffc0db6f97) origin: software input port ifindex: 8 timestamp: Tue Aug 20 10:16:13 2024 475856608 nsec protocol: 0x800 length: 98 original length: 98 drop reason: OVS_DROP_LAST_ACTION Tested-by: Adrian Moreno <amore...@redhat.com> Reviewed-by: Adrian Moreno <amore...@redhat.com> _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev