Re: [ovs-dev] [PATCH net-next 7/8] net/rxrpc: Use min() to simplify the code

[Hongbo Li via dev]

On 2024/8/24 20:06, David Howells wrote:

Hongbo Li <lihongb...@huawei.com> wrote:

-       summary.ack_reason = (sp->ack.reason < RXRPC_ACK__INVALID ?
-                             sp->ack.reason : RXRPC_ACK__INVALID);
+       summary.ack_reason = min(sp->ack.reason, RXRPC_ACK__INVALID);

Can you use umin() rather than min(), please?
I see reason is u8, may I use min_t(u8, sp->ack.reason, RXRPC_ACK__INVALID);

Thanks,
Hongbo

Thanks,
David

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev