Hi Lorenzo,

On 8/22/24 23:59, Lorenzo Bianconi wrote:
> This reverts commit 0158825b2ad575456a0f94775646250099f92463.
> 

This needs a minor rebase.

Same comment as for patch 1/3: please add some information about why
this is reverted.  I know you added it into the cover letter but that
doesn't get committed.

Please add a reference to our internal issue too:
https://issues.redhat.com/browse/FDP-750

Otherwise, this looks good to me.

Regards,
Dumitru


> Signed-off-by: Lorenzo Bianconi <[email protected]>
> ---
>  northd/en-lflow.c        |  3 --
>  northd/inc-proc-northd.c |  1 -
>  northd/northd.c          | 35 ++++++--------------
>  northd/northd.h          |  1 -
>  tests/ovn.at             |  4 +--
>  tests/system-ovn.at      | 71 ++++++++++++++++------------------------
>  6 files changed, 41 insertions(+), 74 deletions(-)
> 
> diff --git a/northd/en-lflow.c b/northd/en-lflow.c
> index f9d7f2459..a713f1598 100644
> --- a/northd/en-lflow.c
> +++ b/northd/en-lflow.c
> @@ -55,8 +55,6 @@ lflow_get_input_data(struct engine_node *node,
>          engine_get_input_data("lr_stateful", node);
>      struct ed_type_ls_stateful *ls_stateful_data =
>          engine_get_input_data("ls_stateful", node);
> -    struct ecmp_nexthop_data *nexthop_data =
> -        engine_get_input_data("ecmp_nexthop", node);
>  
>      lflow_input->sbrec_logical_flow_table =
>          EN_OVSDB_GET(engine_get_input("SB_logical_flow", node));
> @@ -86,7 +84,6 @@ lflow_get_input_data(struct engine_node *node,
>      lflow_input->parsed_routes = &static_routes_data->parsed_routes;
>      lflow_input->route_tables = &static_routes_data->route_tables;
>      lflow_input->route_policies = &route_policies_data->route_policies;
> -    lflow_input->nexthops_table = &nexthop_data->nexthops;
>  
>      struct ed_type_global_config *global_config =
>          engine_get_input_data("global_config", node);
> diff --git a/northd/inc-proc-northd.c b/northd/inc-proc-northd.c
> index cb880b439..06c7ee2b8 100644
> --- a/northd/inc-proc-northd.c
> +++ b/northd/inc-proc-northd.c
> @@ -282,7 +282,6 @@ void inc_proc_northd_init(struct ovsdb_idl_loop *nb,
>      engine_add_input(&en_lflow, &en_bfd_sync, NULL);
>      engine_add_input(&en_lflow, &en_route_policies, NULL);
>      engine_add_input(&en_lflow, &en_static_routes, NULL);
> -    engine_add_input(&en_lflow, &en_ecmp_nexthop, NULL);
>      engine_add_input(&en_lflow, &en_global_config,
>                       node_global_config_handler);
>  
> diff --git a/northd/northd.c b/northd/northd.c
> index 73367b910..51ee5db1d 100644
> --- a/northd/northd.c
> +++ b/northd/northd.c
> @@ -11517,8 +11517,7 @@ add_ecmp_symmetric_reply_flows(struct lflow_table 
> *lflows,
>                                 struct ovn_port *out_port,
>                                 const struct parsed_route *route,
>                                 struct ds *route_match,
> -                               struct lflow_ref *lflow_ref,
> -                               struct simap *nexthops_table)
> +                               struct lflow_ref *lflow_ref)
>  {
>      const struct nbrec_logical_router_static_route *st_route = route->route;
>      struct ds match = DS_EMPTY_INITIALIZER;
> @@ -11553,15 +11552,9 @@ add_ecmp_symmetric_reply_flows(struct lflow_table 
> *lflows,
>      ds_put_cstr(&match, " && (ct.new || ct.est)");
>      ds_put_format(&actions,
>              "ct_commit { ct_label.ecmp_reply_eth = eth.src; "
> -            "ct_mark.ecmp_reply_port = %" PRId64 ";",
> +            "ct_mark.ecmp_reply_port = %" PRId64 ";}; "
> +            "next;",
>              out_port->sb->tunnel_key);
> -
> -    struct simap_node *n = simap_find(nexthops_table, st_route->nexthop);
> -    if (n) {
> -        ds_put_format(&actions, " ct_label.label = %d;", n->data);
> -    }
> -    ds_put_cstr(&actions, " }; next;");
> -
>      ovn_lflow_add_with_hint(lflows, od, S_ROUTER_IN_ECMP_STATEFUL, 100,
>                              ds_cstr(&match), ds_cstr(&actions),
>                              &st_route->header_,
> @@ -11618,8 +11611,7 @@ add_ecmp_symmetric_reply_flows(struct lflow_table 
> *lflows,
>  static void
>  build_ecmp_route_flow(struct lflow_table *lflows, struct ovn_datapath *od,
>                        const struct hmap *lr_ports, struct ecmp_groups_node 
> *eg,
> -                      struct lflow_ref *lflow_ref,
> -                      struct simap *nexthops_table)
> +                      struct lflow_ref *lflow_ref)
>  
>  {
>      bool is_ipv4 = IN6_IS_ADDR_V4MAPPED(&eg->prefix);
> @@ -11676,7 +11668,7 @@ build_ecmp_route_flow(struct lflow_table *lflows, 
> struct ovn_datapath *od,
>                                                       out_port->key)) {
>              add_ecmp_symmetric_reply_flows(lflows, od, lrp_addr_s, out_port,
>                                             route_, &route_match,
> -                                           lflow_ref, nexthops_table);
> +                                           lflow_ref);
>          }
>          ds_clear(&match);
>          ds_put_format(&match, REG_ECMP_GROUP_ID" == %"PRIu16" && "
> @@ -13578,7 +13570,7 @@ build_static_route_flows_for_lrouter(
>          struct ovn_datapath *od, struct lflow_table *lflows,
>          const struct hmap *lr_ports, struct hmap *parsed_routes,
>          struct simap *route_tables, const struct hmap *bfd_connections,
> -        struct lflow_ref *lflow_ref, struct simap *nexthops_table)
> +        struct lflow_ref *lflow_ref)
>  {
>      ovs_assert(od->nbr);
>      ovn_lflow_add_default_drop(lflows, od, S_ROUTER_IN_IP_ROUTING_ECMP,
> @@ -13620,8 +13612,7 @@ build_static_route_flows_for_lrouter(
>      HMAP_FOR_EACH (group, hmap_node, &ecmp_groups) {
>          /* add a flow in IP_ROUTING, and one flow for each member in
>           * IP_ROUTING_ECMP. */
> -        build_ecmp_route_flow(lflows, od, lr_ports, group, lflow_ref,
> -                              nexthops_table);
> +        build_ecmp_route_flow(lflows, od, lr_ports, group, lflow_ref);
>      }
>      const struct unique_routes_node *ur;
>      HMAP_FOR_EACH (ur, hmap_node, &unique_routes) {
> @@ -17060,7 +17051,6 @@ struct lswitch_flow_build_info {
>      struct hmap *parsed_routes;
>      struct hmap *route_policies;
>      struct simap *route_tables;
> -    struct simap *nexthops_table;
>  };
>  
>  /* Helper function to combine all lflow generation which is iterated by
> @@ -17107,8 +17097,7 @@ build_lswitch_and_lrouter_iterate_by_lr(struct 
> ovn_datapath *od,
>      build_ip_routing_pre_flows_for_lrouter(od, lsi->lflows, NULL);
>      build_static_route_flows_for_lrouter(od, lsi->lflows, lsi->lr_ports,
>                                           lsi->parsed_routes, 
> lsi->route_tables,
> -                                         lsi->bfd_connections, NULL,
> -                                         lsi->nexthops_table);
> +                                         lsi->bfd_connections, NULL);
>      build_mcast_lookup_flows_for_lrouter(od, lsi->lflows, &lsi->match,
>                                           &lsi->actions, NULL);
>      build_ingress_policy_flows_for_lrouter(od, lsi->lflows, lsi->lr_ports,
> @@ -17438,8 +17427,7 @@ build_lswitch_and_lrouter_flows(
>      const struct sampling_app_table *sampling_apps,
>      struct hmap *parsed_routes,
>      struct hmap *route_policies,
> -    struct simap *route_tables,
> -    struct simap *nexthops_table)
> +    struct simap *route_tables)
>  {
>  
>      char *svc_check_match = xasprintf("eth.dst == %s", svc_monitor_mac);
> @@ -17477,7 +17465,6 @@ build_lswitch_and_lrouter_flows(
>              lsiv[index].parsed_routes = parsed_routes;
>              lsiv[index].route_tables = route_tables;
>              lsiv[index].route_policies = route_policies;
> -            lsiv[index].nexthops_table = nexthops_table;
>              ds_init(&lsiv[index].match);
>              ds_init(&lsiv[index].actions);
>  
> @@ -17524,7 +17511,6 @@ build_lswitch_and_lrouter_flows(
>              .route_policies = route_policies,
>              .match = DS_EMPTY_INITIALIZER,
>              .actions = DS_EMPTY_INITIALIZER,
> -            .nexthops_table = nexthops_table,
>          };
>  
>          /* Combined build - all lflow generation from lswitch and lrouter
> @@ -17691,8 +17677,7 @@ void build_lflows(struct ovsdb_idl_txn *ovnsb_txn,
>                                      input_data->sampling_apps,
>                                      input_data->parsed_routes,
>                                      input_data->route_policies,
> -                                    input_data->route_tables,
> -                                    input_data->nexthops_table);
> +                                    input_data->route_tables);
>  
>      if (parallelization_state == STATE_INIT_HASH_SIZES) {
>          parallelization_state = STATE_USE_PARALLELIZATION;
> diff --git a/northd/northd.h b/northd/northd.h
> index c7f0b829b..afd5f7113 100644
> --- a/northd/northd.h
> +++ b/northd/northd.h
> @@ -229,7 +229,6 @@ struct lflow_input {
>      struct hmap *parsed_routes;
>      struct hmap *route_policies;
>      struct simap *route_tables;
> -    struct simap *nexthops_table;
>  };
>  
>  extern int parallelization_state;
> diff --git a/tests/ovn.at b/tests/ovn.at
> index 50c9f04da..acf18c4e0 100644
> --- a/tests/ovn.at
> +++ b/tests/ovn.at
> @@ -28717,7 +28717,7 @@ AT_CHECK([
>      for hv in 1 2; do
>          grep table=$ecmp_stateful hv${hv}flows | \
>          grep "priority=100" | \
> -        grep -c 
> "ct(commit,zone=NXM_NX_REG11\\[[0..15\\]],.*exec(move:NXM_OF_ETH_SRC\\[[\\]]->NXM_NX_CT_LABEL\\[[32..79\\]],load:0x[[0-9]]->NXM_NX_CT_MARK\\[[16..31\\]],load:0x[[0-9]]->NXM_NX_CT_LABEL\\[[96..127\\]]))"
> +        grep -c 
> "ct(commit,zone=NXM_NX_REG11\\[[0..15\\]],.*exec(move:NXM_OF_ETH_SRC\\[[\\]]->NXM_NX_CT_LABEL\\[[32..79\\]],load:0x[[0-9]]->NXM_NX_CT_MARK\\[[16..31\\]]))"
>  
>          grep table=$arp_resolve hv${hv}flows | \
>          grep "priority=200" | \
> @@ -28846,7 +28846,7 @@ AT_CHECK([
>      for hv in 1 2; do
>          grep table=$ecmp_stateful hv${hv}flows | \
>          grep "priority=100" | \
> -        grep -c 
> "ct(commit,zone=NXM_NX_REG11\\[[0..15\\]],.*exec(move:NXM_OF_ETH_SRC\\[[\\]]->NXM_NX_CT_LABEL\\[[32..79\\]],load:0x[[0-9]]->NXM_NX_CT_MARK\\[[16..31\\]],load:0x[[0-9]]->NXM_NX_CT_LABEL\\[[96..127\\]]))"
> +        grep -c 
> "ct(commit,zone=NXM_NX_REG11\\[[0..15\\]],.*exec(move:NXM_OF_ETH_SRC\\[[\\]]->NXM_NX_CT_LABEL\\[[32..79\\]],load:0x[[0-9]]->NXM_NX_CT_MARK\\[[16..31\\]]))"
>  
>          grep table=$arp_resolve hv${hv}flows | \
>          grep "priority=200" | \
> diff --git a/tests/system-ovn.at b/tests/system-ovn.at
> index c2e35a74c..0831a2108 100644
> --- a/tests/system-ovn.at
> +++ b/tests/system-ovn.at
> @@ -6172,21 +6172,18 @@ NS_CHECK_EXEC([bob1], [ping -q -c 3 -i 0.3 -w 2 
> 10.0.0.2 | FORMAT_PING], \
>  # and just ensure that the known ethernet address is present.
>  AT_CHECK([ovs-appctl dpctl/dump-conntrack | FORMAT_CT(172.16.0.1) | \
>  sed -e 's/zone=[[0-9]]*/zone=<cleared>/' |
> -sed -e 's/mark=[[0-9]]*/mark=<cleared>/' |
> -sed -e 's/labels=0x[[0-9]]/labels=0x?/'], [0], [dnl
> -icmp,orig=(src=172.16.0.1,dst=10.0.0.2,id=<cleared>,type=8,code=0),reply=(src=10.0.0.2,dst=172.16.0.1,id=<cleared>,type=0,code=0),zone=<cleared>,mark=<cleared>,labels=0x?000000000401020400000000
> -tcp,orig=(src=172.16.0.1,dst=10.0.0.2,sport=<cleared>,dport=<cleared>),reply=(src=10.0.0.2,dst=172.16.0.1,sport=<cleared>,dport=<cleared>),zone=<cleared>,mark=<cleared>,labels=0x?000000000401020400000000,protoinfo=(state=<cleared>)
> +sed -e 's/mark=[[0-9]]*/mark=<cleared>/'], [0], [dnl
> +icmp,orig=(src=172.16.0.1,dst=10.0.0.2,id=<cleared>,type=8,code=0),reply=(src=10.0.0.2,dst=172.16.0.1,id=<cleared>,type=0,code=0),zone=<cleared>,mark=<cleared>,labels=0x401020400000000
> +tcp,orig=(src=172.16.0.1,dst=10.0.0.2,sport=<cleared>,dport=<cleared>),reply=(src=10.0.0.2,dst=172.16.0.1,sport=<cleared>,dport=<cleared>),zone=<cleared>,mark=<cleared>,labels=0x401020400000000,protoinfo=(state=<cleared>)
>  ])
>  
>  # Ensure datapaths show conntrack states as expected
>  # Like with conntrack entries, we shouldn't try to predict
>  # port binding tunnel keys. So omit them from expected labels.
> -AT_CHECK([ovs-appctl dpctl/dump-flows | sed -e 
> 's/label=0x[[0-9]]/label=0x?/' | \
> -grep 'ct_state(+new-est+trk).*ct(.*label=0x?000000000401020400000000/.*)' 
> -c], [0], [dnl
> +AT_CHECK([ovs-appctl dpctl/dump-flows | grep 
> 'ct_state(+new-est+trk).*ct(.*label=0x401020400000000/.*)' -c], [0], [dnl
>  2
>  ])
> -AT_CHECK([[ovs-appctl dpctl/dump-flows | sed -e 
> 's/ct_label(0x[0-9]/ct_label(0x?/' | \
> -grep 'ct_state(-new+est+trk).*ct_label(0x?000000000401020400000000)' -c]], 
> [0], [dnl
> +AT_CHECK([ovs-appctl dpctl/dump-flows | grep 
> 'ct_state(-new+est+trk).*ct_label(0x401020400000000)' -c], [0], [dnl
>  2
>  ])
>  
> @@ -6205,21 +6202,18 @@ NS_CHECK_EXEC([bob1], [ping -q -c 3 -i 0.3 -w 2 
> 10.0.0.2 | FORMAT_PING], \
>  [0], [dnl
>  3 packets transmitted, 3 received, 0% packet loss, time 0ms
>  ])
> -AT_CHECK([ovs-appctl dpctl/dump-flows | sed -e 
> 's/label=0x[[0-9]]/label=0x?/' | \
> -grep 'ct_state(+new-est+trk).*ct(.*label=0x?000000001001020400000000/.*)' 
> -c], [0], [dnl
> +AT_CHECK([ovs-appctl dpctl/dump-flows | grep 
> 'ct_state(+new-est+trk).*ct(.*label=0x1001020400000000/.*)' -c], [0], [dnl
>  2
>  ])
> -AT_CHECK([[ovs-appctl dpctl/dump-flows | sed -e 
> 's/ct_label(0x[0-9]/ct_label(0x?/' | \
> -grep 'ct_state(-new+est+trk).*ct_label(0x?000000001001020400000000)' -c]], 
> [0], [dnl
> +AT_CHECK([ovs-appctl dpctl/dump-flows | grep 
> 'ct_state(-new+est+trk).*ct_label(0x1001020400000000)' -c], [0], [dnl
>  2
>  ])
>  
> -AT_CHECK([ovs-appctl dpctl/dump-conntrack | grep 1001020400000000 | 
> FORMAT_CT(172.16.0.1) | \
> +AT_CHECK([ovs-appctl dpctl/dump-conntrack | grep 0x1001020400000000 | 
> FORMAT_CT(172.16.0.1) | \
>  sed -e 's/zone=[[0-9]]*/zone=<cleared>/' |
> -sed -e 's/mark=[[0-9]]*/mark=<cleared>/' |
> -sed -e 's/labels=0x[[0-9]]/labels=0x?/' | sort], [0], [dnl
> -icmp,orig=(src=172.16.0.1,dst=10.0.0.2,id=<cleared>,type=8,code=0),reply=(src=10.0.0.2,dst=172.16.0.1,id=<cleared>,type=0,code=0),zone=<cleared>,mark=<cleared>,labels=0x?000000001001020400000000
> -tcp,orig=(src=172.16.0.1,dst=10.0.0.2,sport=<cleared>,dport=<cleared>),reply=(src=10.0.0.2,dst=172.16.0.1,sport=<cleared>,dport=<cleared>),zone=<cleared>,mark=<cleared>,labels=0x?000000001001020400000000,protoinfo=(state=<cleared>)
> +sed -e 's/mark=[[0-9]]*/mark=<cleared>/' | sort], [0], [dnl
> +icmp,orig=(src=172.16.0.1,dst=10.0.0.2,id=<cleared>,type=8,code=0),reply=(src=10.0.0.2,dst=172.16.0.1,id=<cleared>,type=0,code=0),zone=<cleared>,mark=<cleared>,labels=0x1001020400000000
> +tcp,orig=(src=172.16.0.1,dst=10.0.0.2,sport=<cleared>,dport=<cleared>),reply=(src=10.0.0.2,dst=172.16.0.1,sport=<cleared>,dport=<cleared>),zone=<cleared>,mark=<cleared>,labels=0x1001020400000000,protoinfo=(state=<cleared>)
>  ])
>  # Check entries in table 76 and 77 expires w/o traffic
>  OVS_WAIT_UNTIL([
> @@ -6241,11 +6235,10 @@ NS_CHECK_EXEC([alice1], [ping -q -c 3 -i 0.3 -w 2 
> 172.16.0.1 | FORMAT_PING], \
>  3 packets transmitted, 3 received, 0% packet loss, time 0ms
>  ])
>  
> -AT_CHECK([ovs-appctl dpctl/dump-conntrack | grep 401020500000000 | 
> FORMAT_CT(172.16.0.1) | \
> +AT_CHECK([ovs-appctl dpctl/dump-conntrack | grep 0x401020500000000 | 
> FORMAT_CT(172.16.0.1) | \
>  sed -e 's/zone=[[0-9]]*/zone=<cleared>/' |
> -sed -e 's/mark=[[0-9]]*/mark=<cleared>/' |
> -sed -e 's/labels=0x[[0-9]]/labels=0x?/' | sort], [0], [dnl
> -tcp,orig=(src=172.16.0.1,dst=10.0.0.2,sport=<cleared>,dport=<cleared>),reply=(src=10.0.0.2,dst=172.16.0.1,sport=<cleared>,dport=<cleared>),zone=<cleared>,mark=<cleared>,labels=0x?000000000401020500000000,protoinfo=(state=<cleared>)
> +sed -e 's/mark=[[0-9]]*/mark=<cleared>/' | sort], [0], [dnl
> +tcp,orig=(src=172.16.0.1,dst=10.0.0.2,sport=<cleared>,dport=<cleared>),reply=(src=10.0.0.2,dst=172.16.0.1,sport=<cleared>,dport=<cleared>),zone=<cleared>,mark=<cleared>,labels=0x401020500000000,protoinfo=(state=<cleared>)
>  ])
>  
>  OVS_APP_EXIT_AND_WAIT([ovn-controller])
> @@ -6395,12 +6388,11 @@ NS_CHECK_EXEC([bob1], [ping -q -c 3 -i 0.3 -w 2 
> fd01::2 | FORMAT_PING], \
>  # Ensure datapaths show conntrack states as expected
>  # Like with conntrack entries, we shouldn't try to predict
>  # port binding tunnel keys. So omit them from expected labels.
> -AT_CHECK([ovs-appctl dpctl/dump-flows | sed -e 
> 's/label=0x[[0-9]]/label=0x?/' | \
> -grep 'ct_state(+new-est+trk).*ct(.*label=0x?000000000401020400000000/.*)' 
> -c], [0], [dnl
> +AT_CHECK([ovs-appctl dpctl/dump-flows | grep 
> 'ct_state(+new-est+trk).*ct(.*label=0x401020400000000/.*)' -c], [0], [dnl
>  2
>  ])
> -AT_CHECK([[ovs-appctl dpctl/dump-flows | sed -e 
> 's/ct_label(0x[0-9]/ct_label(0x?/' | \
> -grep 'ct_state(-new+est+trk).*ct_label(0x?000000000401020400000000)' -c]], 
> [0], [dnl
> +
> +AT_CHECK([ovs-appctl dpctl/dump-flows | grep 
> 'ct_state(-new+est+trk).*ct_label(0x401020400000000)' -c], [0], [dnl
>  2
>  ])
>  
> @@ -6409,10 +6401,9 @@ grep 
> 'ct_state(-new+est+trk).*ct_label(0x?000000000401020400000000)' -c]], [0],
>  # and just ensure that the known ethernet address is present.
>  AT_CHECK([ovs-appctl dpctl/dump-conntrack | FORMAT_CT(fd01::2) | \
>  sed -e 's/zone=[[0-9]]*/zone=<cleared>/' |
> -sed -e 's/mark=[[0-9]]*/mark=<cleared>/' |
> -sed -e 's/labels=0x[[0-9]]/labels=0x?/' | sort], [0], [dnl
> -icmpv6,orig=(src=fd07::1,dst=fd01::2,id=<cleared>,type=128,code=0),reply=(src=fd01::2,dst=fd07::1,id=<cleared>,type=129,code=0),zone=<cleared>,mark=<cleared>,labels=0x?000000000401020400000000
> -tcp,orig=(src=fd07::1,dst=fd01::2,sport=<cleared>,dport=<cleared>),reply=(src=fd01::2,dst=fd07::1,sport=<cleared>,dport=<cleared>),zone=<cleared>,mark=<cleared>,labels=0x?000000000401020400000000,protoinfo=(state=<cleared>)
> +sed -e 's/mark=[[0-9]]*/mark=<cleared>/' | sort], [0], [dnl
> +icmpv6,orig=(src=fd07::1,dst=fd01::2,id=<cleared>,type=128,code=0),reply=(src=fd01::2,dst=fd07::1,id=<cleared>,type=129,code=0),zone=<cleared>,mark=<cleared>,labels=0x401020400000000
> +tcp,orig=(src=fd07::1,dst=fd01::2,sport=<cleared>,dport=<cleared>),reply=(src=fd01::2,dst=fd07::1,sport=<cleared>,dport=<cleared>),zone=<cleared>,mark=<cleared>,labels=0x401020400000000,protoinfo=(state=<cleared>)
>  ])
>  
>  # Flush conntrack entries for easier output parsing of next test.
> @@ -6429,21 +6420,18 @@ NS_CHECK_EXEC([bob1], [ping -q -c 3 -i 0.3 -w 2 
> fd01::2 | FORMAT_PING], \
>  3 packets transmitted, 3 received, 0% packet loss, time 0ms
>  ])
>  
> -AT_CHECK([ovs-appctl dpctl/dump-flows | sed -e 
> 's/label=0x[[0-9]]/label=0x?/' | \
> -grep 'ct_state(+new-est+trk).*ct(.*label=0x?000000001001020400000000/.*)' 
> -c], [0], [dnl
> +AT_CHECK([ovs-appctl dpctl/dump-flows | grep 
> 'ct_state(+new-est+trk).*ct(.*label=0x1001020400000000/.*)' -c], [0], [dnl
>  2
>  ])
> -AT_CHECK([[ovs-appctl dpctl/dump-flows | sed -e 
> 's/ct_label(0x[0-9]/ct_label(0x?/' | \
> -grep 'ct_state(-new+est+trk).*ct_label(0x?000000001001020400000000)' -c]], 
> [0], [dnl
> +AT_CHECK([ovs-appctl dpctl/dump-flows | grep 
> 'ct_state(-new+est+trk).*ct_label(0x1001020400000000)' -c], [0], [dnl
>  2
>  ])
>  
> -AT_CHECK([ovs-appctl dpctl/dump-conntrack | grep 1001020400000000 | 
> FORMAT_CT(fd01::2) | \
> +AT_CHECK([ovs-appctl dpctl/dump-conntrack | grep 0x1001020400000000 | 
> FORMAT_CT(fd01::2) | \
>  sed -e 's/zone=[[0-9]]*/zone=<cleared>/' |
> -sed -e 's/mark=[[0-9]]*/mark=<cleared>/' |
> -sed -e 's/labels=0x[[0-9]]/labels=0x?/'], [0], [dnl
> -icmpv6,orig=(src=fd07::1,dst=fd01::2,id=<cleared>,type=128,code=0),reply=(src=fd01::2,dst=fd07::1,id=<cleared>,type=129,code=0),zone=<cleared>,mark=<cleared>,labels=0x?000000001001020400000000
> -tcp,orig=(src=fd07::1,dst=fd01::2,sport=<cleared>,dport=<cleared>),reply=(src=fd01::2,dst=fd07::1,sport=<cleared>,dport=<cleared>),zone=<cleared>,mark=<cleared>,labels=0x?000000001001020400000000,protoinfo=(state=<cleared>)
> +sed -e 's/mark=[[0-9]]*/mark=<cleared>/'], [0], [dnl
> +icmpv6,orig=(src=fd07::1,dst=fd01::2,id=<cleared>,type=128,code=0),reply=(src=fd01::2,dst=fd07::1,id=<cleared>,type=129,code=0),zone=<cleared>,mark=<cleared>,labels=0x1001020400000000
> +tcp,orig=(src=fd07::1,dst=fd01::2,sport=<cleared>,dport=<cleared>),reply=(src=fd01::2,dst=fd07::1,sport=<cleared>,dport=<cleared>),zone=<cleared>,mark=<cleared>,labels=0x1001020400000000,protoinfo=(state=<cleared>)
>  ])
>  
>  # Check entries in table 76 and 77 expires w/o traffic
> @@ -6463,11 +6451,10 @@ NS_CHECK_EXEC([alice1], [ping -q -c 3 -i 0.3 -w 2 
> fd07::1 | FORMAT_PING], \
>  3 packets transmitted, 3 received, 0% packet loss, time 0ms
>  ])
>  
> -AT_CHECK([ovs-appctl dpctl/dump-conntrack | grep 1001020400000000 | 
> FORMAT_CT(fd07::1) | \
> +AT_CHECK([ovs-appctl dpctl/dump-conntrack | grep 0x1001020400000000 | 
> FORMAT_CT(fd07::1) | \
>  sed -e 's/zone=[[0-9]]*/zone=<cleared>/' |
> -sed -e 's/mark=[[0-9]]*/mark=<cleared>/' |
> -sed -e 's/labels=0x[[0-9]]/labels=0x?/' | sort], [0], [dnl
> -tcp,orig=(src=fd07::1,dst=fd01::2,sport=<cleared>,dport=<cleared>),reply=(src=fd01::2,dst=fd07::1,sport=<cleared>,dport=<cleared>),zone=<cleared>,mark=<cleared>,labels=0x?000000001001020400000000,protoinfo=(state=<cleared>)
> +sed -e 's/mark=[[0-9]]*/mark=<cleared>/' | sort], [0], [dnl
> +tcp,orig=(src=fd07::1,dst=fd01::2,sport=<cleared>,dport=<cleared>),reply=(src=fd01::2,dst=fd07::1,sport=<cleared>,dport=<cleared>),zone=<cleared>,mark=<cleared>,labels=0x1001020400000000,protoinfo=(state=<cleared>)
>  ])
>  
>  OVS_APP_EXIT_AND_WAIT([ovn-controller])

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to