Currently, at every call of IPTABLES_ACCEPT() an iptables rule gets
added. Such rule is supposed to be removed on exit, but the current
syntax for deleting the rule is incorrect, resulting in a leftover
rule after execution.

Fix it by correcting the deletion command.

Fixes: 5e06e7ac99dc ("tests: Refactor the iptables accept rule.")
Signed-off-by: Paolo Valerio <pvale...@redhat.com>
---
 tests/ovs-macros.at | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/ovs-macros.at b/tests/ovs-macros.at
index df2835747..4cc8e7bc8 100644
--- a/tests/ovs-macros.at
+++ b/tests/ovs-macros.at
@@ -365,7 +365,7 @@ dnl to reject input traffic from bridges such as 
br-underlay.
 dnl Add a rule to always accept the traffic.
 m4_define([IPTABLES_ACCEPT],
   [AT_CHECK([iptables -I INPUT 1 -i $1 -j ACCEPT])
-   on_exit 'iptables -D INPUT 1 -i $1'])
+   on_exit 'iptables -D INPUT 1'])
 
 dnl Required to let conntrack start tracking the packets outside ovs
 m4_define([IPTABLES_CT],
-- 
2.46.0

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to