On 12/18/24 3:17 PM, [email protected] wrote: > Hi Felix, > thanks for these series (northd and controller side), I picked them up > yesterday to integrate NAT/LB route advertisements originally proposed > by fnordahl. They were easy to work with. I don't have yet > comprehensive enough review, but I'll drop some thoughts/potential > issues that I ran into (into individual patches). >
Hi Martin, Felix, I also did a first full round of review of this series and shared what comments/suggestions/questions I had on the individual patches. Martin, regarding the NAT/LB route advertisements, if it's not too much work, it would be great if you could post those too. I'm trying to review all BGP related series together, applied in a local branch. Regards, Dumitru > Martin. > > On Wed, 2024-12-18 at 11:24 +0100, Felix Huettner via dev wrote: >> Hi everyone, >> >> this is the northd part of the OVN Fabric integration series >> https://mail.openvswitch.org/pipermail/ovs-dev/2024-November/418554.html >> . >> >> By the end of the series northd can announce routes by writing to the >> sb Advertised_Route table. >> Northd can also learn routes by reading from the sb Learned_Route >> table. >> >> There is a parallel patch series that works on this from the side >> of the ovn-controller: >> https://patchwork.ozlabs.org/project/ovn/list/?series=437158 >> >> The only difference to v1 is that this has been rebased against the >> lastest main branch. >> >> Felix Huettner (6): >> northd: Add route table to southbound and sync. >> northd: Add filtering which routes to advertise. >> northd: Handle learned routes. >> northd: Remove learned routes if lrp is removed. >> northd: Allow announcing individual host routes. >> northd: Sync routing data to pb. >> >> NEWS | 12 + >> ic/ovn-ic.c | 21 -- >> lib/ovn-util.c | 22 ++ >> lib/ovn-util.h | 2 + >> lib/stopwatch-names.h | 2 + >> northd/automake.mk | 4 + >> northd/en-advertised-route-sync.c | 444 >> ++++++++++++++++++++++++++++++ >> northd/en-advertised-route-sync.h | 43 +++ >> northd/en-learned-route-sync.c | 226 +++++++++++++++ >> northd/en-learned-route-sync.h | 31 +++ >> northd/en-lflow.c | 5 +- >> northd/en-northd-output.c | 8 + >> northd/en-northd-output.h | 2 + >> northd/inc-proc-northd.c | 24 +- >> northd/northd.c | 346 ++++++++++++----------- >> northd/northd.h | 87 +++++- >> ovn-nb.xml | 127 +++++++++ >> tests/ovn-northd.at | 362 +++++++++++++++++++++--- >> 18 files changed, 1550 insertions(+), 218 deletions(-) >> create mode 100644 northd/en-advertised-route-sync.c >> create mode 100644 northd/en-advertised-route-sync.h >> create mode 100644 northd/en-learned-route-sync.c >> create mode 100644 northd/en-learned-route-sync.h >> >> >> base-commit: ebe5d70122ce0f74067858f5cb19276c852a81da > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
