On 29 Jan 2025, at 15:28, Ilya Maximets wrote:
> On 1/29/25 11:00, Eelco Chaudron wrote:
>> When TC parses the flow to install, it assumes that the datalink type
>> mask is set. However, this may not always be the case, for example,
>> when multiple VLANs exist but only one is enabled (vlan-limit).
>>
>> This patch will only process the dl_type if the mask is set. It also
>> includes a unit test to verify that the TC rules are offloaded in this
>> case.
>>
>> Fixes: 1be33d52af77 ("netdev-tc-offloads: Don't offload header modification
>> on ip fragments.")
>> Signed-off-by: Eelco Chaudron <[email protected]>
>>
>> ---
>> v3: - Fixed all Ilya's style comments
>> v2: - Adding is_ip_any() function that got deleted somehow
>> - Fixed alignment
>> ---
>> lib/netdev-offload-tc.c | 11 +++++++----
>> tests/system-offloads-traffic.at | 32 +++++++++++++++++++++++++++++++-
>> 2 files changed, 38 insertions(+), 5 deletions(-)
>
> Acked-by: Ilya Maximets <[email protected]>
Thanks Ilya and Aaron, for the reviews. I’ve applied the patch to main and
backported it to 3.3.
Cheers,
Eelco
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
