On 2/5/25 17:03, Eelco Chaudron wrote: > On ctx->error free the allocated encap_data. > > Signed-off-by: Eelco Chaudron <[email protected]> > --- > ofproto/ofproto-dpif-xlate.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c > index 4cc7001a5..0289bc0b8 100644 > --- a/ofproto/ofproto-dpif-xlate.c > +++ b/ofproto/ofproto-dpif-xlate.c > @@ -7007,6 +7007,8 @@ xlate_generic_encap_action(struct xlate_ctx *ctx, > /* The actual encap datapath action will be generated at next > commit. */ > ctx->pending_encap = true; > ctx->encap_data = encap_data; > + } else { > + ofpbuf_delete(encap_data); > } > } >
I think, rewrite_flow_push_nsh() should be changed instead. It should not set error and return non-NULL buf at the same time. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
