On 2/7/25 1:08 PM, Ales Musil wrote: > On Fri, Feb 7, 2025 at 12:41 PM Ilya Maximets <[email protected]> wrote: > >> On 2/7/25 03:24, Numan Siddique wrote: >>> On Tue, Feb 4, 2025 at 3:39 PM Mark Michelson <[email protected]> >> wrote: >>>> >>>> Hi Numan, >>>> >>>> Thanks for the updated patch. >>>> >>>> Acked-by: Mark Michelson <[email protected]> >>> >>> Thanks Mark. I applied this patch to main after adding the below >> changes. >>> >>> --- >>> diff --git a/.ci/ovn-kubernetes/Dockerfile >> b/.ci/ovn-kubernetes/Dockerfile >>> index caaa41708c..b34cdbea1f 100644 >>> --- a/.ci/ovn-kubernetes/Dockerfile >>> +++ b/.ci/ovn-kubernetes/Dockerfile >>> @@ -81,6 +81,8 @@ COPY --from=ovnbuilder >>> /tmp/ovn/ovs/rpm/rpmbuild/RPMS/noarch/*rpm ./ >>> >>> # Delete network-scripts-openvswitch rpm generated earlier as it >> requires >>> # network-scripts package and it is no longer available from Fedora 41. >>> +# TODO: Remove the below deletion of network-scripts rpm Once we move >>> +# our ovs submodule to this commit - ed133507f0c12e >>> RUN rm -f network-scripts* >>> RUN dnf install -y *.rpm && rm -f *.rpm >>> >>> ----- >>> >>> Once we move ovs submodule to have this commit >>> >> https://github.com/openvswitch/ovs/commit/ed133507f0c12e182cd275aff18f58425eb511d1 >>> we don't need to delete the networks-scripts rpm. I tried including >>> that ovs submodule, but the ovs-dpdk job failed [1] >>> Looks like OVS compilation is failing on Fedora 41 with dpdk enabled. >>> >>> I couldn't debug that issue. So I went ahead and applied this patch. >>> >>> Numan >>> >>> >>> [1] - >> https://github.com/numansiddique/ovn/actions/runs/13183104652/job/36798831741 >>> >>> * If someone wants to take a look at this issue. >>> >>> libtool: compile: env REAL_CC=gcc "CHECK=sparse -Wsparse-error -I >>> ./include/sparse -I ./include -m64 -I /usr/local/include -I >>> /usr/include/x86_64-linux-gnu " cgcc -target=x86_64 >>> -target=host_os_specs -D__MMX__=1 -D__MMX_WITH_SSE__=1 >>> -D__SSE2_MATH__=1 -D__SSE_MATH__=1 -D__SSE__=1 -D__SSE2__=1 >>> -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib >>> -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith >>> -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter >>> -Wbad-function-cast -Wcast-align -Wstrict-prototypes >>> -Wold-style-definition -Wmissing-prototypes >>> -Wmissing-field-initializers -fno-strict-aliasing -Wswitch-bool >>> -Wlogical-not-parentheses -Wsizeof-array-argument -Wbool-compare >>> -Wshift-negative-value -Wduplicated-cond -Wshadow >>> -Wmultistatement-macros -Wcast-align=strict -mssse3 >>> -I/workspace/dpdk-dir/include -I/workspace/ovn-tmp/dpdk-dir/include >>> -include rte_config.h -mrtm -Werror -D_FILE_OFFSET_BITS=64 -MT >>> lib/dhparams.lo -MD -MP -MF lib/.deps/dhparams.Tpo -c lib/dhparams.c >>> -o lib/dhparams.o >>> 890lib/netdev-dpdk.c: In function 'netdev_dpdk_vhost_client_reconfigure': >>> 891lib/netdev-dpdk.c:6440:13: error: >>> 'rte_vhost_driver_set_max_queue_num' is deprecated: Symbol is not yet >>> part of stable ABI [-Werror=deprecated-declarations] >>> 892 6440 | err = rte_vhost_driver_set_max_queue_num(dev->vhost_id, >> max_qp); >>> 893 | ^~~ >>> 894In file included from lib/netdev-dpdk.c:43: >>> 895/workspace/dpdk-dir/include/rte_vhost.h:626:1: note: declared here >>> 896 626 | rte_vhost_driver_set_max_queue_num(const char *path, >>> uint32_t max_queue_pairs); >>> 897 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> >> >> OVS 3.5 requires DPDK 24.11, which is only available in 42 and rawhide. >> > > DPDK for the CI container is installed from DPDK git/tarball directly, for > that we only need to bump DPDK_VER in utilities/containers/prepare.sh. >
FWIW that will happen when this patch gets merged: https://patchwork.ozlabs.org/project/ovn/patch/0ca8df5da12183d90576e2f7ff4ebe644ba8d35e.1738849473.git.felix.huettner@stackit.cloud/ Regards, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
