On 2/6/25 3:19 PM, Felix Huettner via dev wrote: > For each vrf we use we open a netlink watcher. > This allows us to reconcile on changed route entries from outside > routing agents. > > Acked-by: Frode Nordahl <[email protected]> > Acked-by: Lorenzo Bianconi <[email protected]> > Acked-by: Dumitru Ceara <[email protected]> > Signed-off-by: Felix Huettner <[email protected]> > ---
Hi Felix, > diff --git a/controller/route-table-notify-stub.c > b/controller/route-table-notify-stub.c > new file mode 100644 > index 000000000..f58897f03 > --- /dev/null > +++ b/controller/route-table-notify-stub.c > @@ -0,0 +1,56 @@ > +/* > + * Copyright (c) 2025, STACKIT GmbH & Co. KG > + * > + * Licensed under the Apache License, Version 2.0 (the "License"); > + * you may not use this file except in compliance with the License. > + * You may obtain a copy of the License at: > + * > + * http://www.apache.org/licenses/LICENSE-2.0 > + * > + * Unless required by applicable law or agreed to in writing, software > + * distributed under the License is distributed on an "AS IS" BASIS, > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > + * See the License for the specific language governing permissions and > + * limitations under the License. > + */ > + > +#include <config.h> > + > +#include <stdbool.h> > + > +#include "openvswitch/compiler.h" > +#include "route-table-notify.h" > + > +bool > +route_table_notify_run(void) > +{ > + return false; > +} > + > +void > +route_table_notify_wait(void) > +{ > +} > + > +void > +route_table_add_watch_request(struct hmap *route_table_watches OVS_UNUSED, > + uint32_t table_id OVS_UNUSED) > +{ > +} > + > +void > +route_table_watch_request_cleanup(struct hmap *route_table_watches > OVS_UNUSED) > +{ > +} > + > +void > +route_table_notify_update_watches( > + const struct hmap *route_table_watches OVS_UNUSED) > +{ > +} > + > +void > +route_table_notify_destroy(void) > +{ > +} > + Nit: one newline too many. With that my ack stands: Acked-by: Dumitru Ceara <[email protected]> Thanks, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
