On 2/13/25 1:56 PM, Paulo Guilherme da Silva via dev wrote:
> This commit adds the ability for ovn-ic to filter routes between VPCs.
> In use cases where the user is using vpc-peering(route tag) handling
> multiple points of redistribution, when we connect more than one TS in
> the same Logical Router it is essential that we have control over which
> routes will be filtered or advertised by transit switch.
> 
> Signed-off-by: Lucas Vargas Dias <[email protected]>
> Signed-off-by: Paulo Guilherme da Silva <[email protected]>
> ---

Hi Paulo,

Thanks for the patch.  The robot is complaining about the sign-offs because:

1. the patch needs to have a sign-off from the main author, in this case:

Author: Paulo Guilherme da Silva <[email protected]>

must

Signed-off-by: Paulo Guilherme da Silva <[email protected]>

2. all co-authors must be listed as co-authors:

Co-authored-by: Lucas Vargas Dias <[email protected]>

3. all co-authors must also sign-off:

Signed-off-by: Lucas Vargas Dias <[email protected]>

https://github.com/ovn-org/ovn/blob/2dd45736e8511d25da42c27d07caef5d0224b546/Documentation/internals/contributing/submitting-patches.rst#tags

To summarize, the correct way to attribute authorship of this patch is
probably:

Co-authored-by: Lucas Vargas Dias <[email protected]>
Signed-off-by: Lucas Vargas Dias <[email protected]>
Signed-off-by: Paulo Guilherme da Silva <[email protected]>

Regards,
Dumitru

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to